Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(call): do not update participants list often when not in the call #11038

Merged
merged 1 commit into from
Nov 30, 2023
Merged

fix(call): do not update participants list often when not in the call #11038

merged 1 commit into from
Nov 30, 2023

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Nov 29, 2023 •
edited
Loading

☑️ Resolves

  • Hopefully reduce a server load during start of the call for large amount of participants:
    • Apply fast update only when user is in the call and has tab visible
    • Debounce fetching participants list when join the conversation (3s when conversation has no call, 15s otherwise - enough time to join call and not trigger fetch request)

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

To test locally:

  • When in chat and someone joins conversation and call within 15s - should be only one request in Networks
  • When in call and someone joins conversation and call within 5s - should be only one request in Networks

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences

@Antreesy Antreesy added this to the 💞 Following Major (29) milestone Nov 29, 2023
@Antreesy Antreesy self-assigned this Nov 29, 2023
DorraJaouad
DorraJaouad approved these changes Nov 29, 2023
View reviewed changes
src/mixins/getParticipants.js Outdated Show resolved Hide resolved
src/mixins/getParticipants.js Outdated Show resolved Hide resolved
DorraJaouad
DorraJaouad requested changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again I didn't mean to approve :(

@Antreesy
do not update participants list often when not in the call
9489c3d 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/noid/reduce-fetch-participants branch from c6b99d7 to 9489c3d Compare November 30, 2023 08:58
@Antreesy Antreesy requested a review from DorraJaouad November 30, 2023 09:01
DorraJaouad
DorraJaouad approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better, thanks

@Antreesy
Copy link
Contributor Author

Antreesy commented Nov 30, 2023 •
edited
Loading

slow and fast debounces are parallel, looking for a way to fix it

UPD: didn't find a quick solution, will raise a follow-up

@Antreesy Antreesy marked this pull request as draft November 30, 2023 09:37
@Antreesy Antreesy marked this pull request as ready for review November 30, 2023 10:10
@Antreesy Antreesy merged commit 024b48f into main Nov 30, 2023
37 checks passed
@Antreesy Antreesy deleted the fix/noid/reduce-fetch-participants branch November 30, 2023 10:17
@Antreesy
Copy link
Contributor Author

/backport to stable28

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 30, 2023
Merged
@Antreesy Antreesy mentioned this pull request Nov 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review enhancement feature: call 📹 Voice and video calls feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
v19.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
3 participants
@Antreesy @nickvergessen @DorraJaouad