Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(File share authentication): Remove unnecessary options #11132

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Fix(File share authentication): Remove unnecessary options #11132

merged 2 commits into from
Dec 6, 2023

Conversation

DorraJaouad
Copy link
Contributor

☑️ Resolves

What's changed ?

  • Media Settings doesn't include "always show preview for this conversation" as the password request generates a new room each time.
  • "silent call" option is hidden as it is important to ping the share owner about the request call.
  • Removed an extra div in the button component of requesting password

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🚧 Tasks

  • Code review

🏁 Checklist

@DorraJaouad
fix(Public share authentication): hide unnecessary options
98510f2 
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad
Remove extra div
a197de8 
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad added 3. to review enhancement feature: frontend 🖌️ "Web UI" client feature: talk-sidebar ⬅️ Sidebar integration of Talk into other apps like sharing and documents labels Dec 6, 2023
@DorraJaouad DorraJaouad added this to the 💞 Following Major (29) milestone Dec 6, 2023
@DorraJaouad DorraJaouad requested a review from Antreesy December 6, 2023 09:14
@DorraJaouad DorraJaouad self-assigned this Dec 6, 2023
@DorraJaouad
Copy link
Contributor Author

/backport to stable28

Antreesy
Antreesy approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@Antreesy Antreesy merged commit b2d5cca into main Dec 6, 2023
36 checks passed
@Antreesy Antreesy deleted the fix/10759/auth-file-share branch December 6, 2023 16:00
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

Assignees

@DorraJaouad DorraJaouad

Labels
3. to review enhancement feature: frontend 🖌️ "Web UI" client feature: talk-sidebar ⬅️ Sidebar integration of Talk into other apps like sharing and documents
Projects
None yet
Milestone
v19.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
2 participants
@DorraJaouad @Antreesy