Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable27] refactor: make browserCheck an util #11136

Merged
merged 3 commits into from
Dec 7, 2023
Merged

[stable27] refactor: make browserCheck an util #11136

merged 3 commits into from
Dec 7, 2023

Conversation

SystemKeeper
Copy link
Contributor

Manual backport of #11009 to stable27

🏁 Checklist

@SystemKeeper SystemKeeper added this to the 💚 Next Patch (27) milestone Dec 6, 2023
@SystemKeeper SystemKeeper changed the base branch from main to stable27 December 6, 2023 13:52
@SystemKeeper SystemKeeper marked this pull request as draft December 6, 2023 13:53
@ShGKme @SystemKeeper
refactor: make browserCheck an util
1b5a579 
- There is no need to be a mixin, it has nothing Vue-related or reactive
- Move to utils
- Refactor computed and Vue component methods to exported constants and functions

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@SystemKeeper SystemKeeper force-pushed the refactor/browser-detection-stable27 branch from b817c14 to 1b5a579 Compare December 6, 2023 13:58
@SystemKeeper SystemKeeper marked this pull request as ready for review December 6, 2023 13:59
@SystemKeeper
Copy link
Contributor Author

Sorry, selected main by accident...

@ShGKme @SystemKeeper
refactor: remove workaround for Safari in browserCheck
1c79189 
- faisalman/ua-parser-js#599 is fixed in 1.0.32

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
Copy link
Contributor

ShGKme commented Dec 6, 2023 •
edited
Loading

Should be backported together with

@SystemKeeper
Fix use of blockCalls in vue template
dc3ef3f 
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
@SystemKeeper
Copy link
Contributor Author

Should be backported together with

Good point, added it

Antreesy
Antreesy approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@nickvergessen nickvergessen merged commit b40406d into stable27 Dec 7, 2023
23 checks passed
@nickvergessen nickvergessen deleted the refactor/browser-detection-stable27 branch December 7, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@ShGKme ShGKme ShGKme approved these changes

Assignees
No one assigned
Labels
3. to review feature: frontend 🖌️ "Web UI" client technical debt
Projects
None yet
Milestone
v17.1.4
Development

Successfully merging this pull request may close these issues.
4 participants
@SystemKeeper @ShGKme @Antreesy @nickvergessen