Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RecordingConsentSettings): Disable toggle button when breakout is active #11137

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Dec 6, 2023

☑️ Resolves

Breakout rooms session should be closed when the moderator wants to toggle the consent requirement in the conversation settings . It renders Bad request otherwise.
Therefore, the toggle button is disabled when a session is active.

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

(Sentence is outdated)

🏚️ Before 🏡 After
image image

🚧 Tasks

  • Code review
  • Wording

🏁 Checklist

@DorraJaouad
Copy link
Contributor Author

/backport to stable28

Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic works fine, tested.
Not sure about wording though.

…s active and add hint

Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad force-pushed the fix/10759/recording-consent-in-breakout-rooms branch from 960aa53 to 82166fb Compare December 6, 2023 16:51
@DorraJaouad DorraJaouad enabled auto-merge December 6, 2023 16:53
@DorraJaouad DorraJaouad merged commit e556811 into main Dec 6, 2023
36 checks passed
@DorraJaouad DorraJaouad deleted the fix/10759/recording-consent-in-breakout-rooms branch December 6, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants