-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(shares): use nextcloud/upload
to track upload progress
#11198
Conversation
2eaf461
to
5830ddb
Compare
1e80b79
to
0cd7591
Compare
This comment was marked as resolved.
This comment was marked as resolved.
src/components/MessagesList/MessagesGroup/Message/MessagePart/FilePreview.vue
Outdated
Show resolved
Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessagePart/FilePreview.vue
Outdated
Show resolved
Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessagePart/FilePreview.vue
Outdated
Show resolved
Hide resolved
0cd7591
to
7d82327
Compare
Rebased, updated style of NcProgressBar to |
src/components/MessagesList/MessagesGroup/Message/MessagePart/FilePreview.vue
Show resolved
Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessagePart/FilePreview.vue
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Antreesy would it be possible to put it to the left of the title?
In the first option there's not enough contrast with the background and the shapes below make it a bit confusing, while in the second option I fear that the indicator might be too far from the title and icon.
That wouldn't work for the files with a preview and without a title, like images / text |
@marcoambrosini If you're not ready to come up quickly with a solution, we could split out the design changes into follow-up and merge only library + code for now |
@Antreesy this is good too! |
0adf0ae
to
cb6d3df
Compare
src/components/MessagesList/MessagesGroup/Message/MessagePart/FilePreview.vue
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested 🦅
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
cb6d3df
to
467dc40
Compare
☑️ Resolves
nextcloud/upload
library to perform file uploads to serveruploadFiles
action into 4 smaller manageable actions🖌️ UI Checklist
🖼️ Screenshots / Screencasts
loading.mp4
🚧 TODO
🏁 Checklist