-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chat): API specs for "Edit message" #11207
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
8740f9d
to
b8edaca
Compare
Maybe it’s obvious, but:
? |
As per overview
But yeah will have to be handled explicitly not sure where I dropped it when copying over |
b1e5614
to
35e51d5
Compare
Signed-off-by: Joas Schilling <coding@schilljs.com>
9631669
to
74283ad
Compare
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
74283ad
to
14220aa
Compare
Fixed |
API allows to edit a message to an empty message. |
I think this leads the edit to act like deleting the message ? |
Not at the moment at least, right now it’s just an edited, empty message. I don’t think it should act as deleted personally, because you can’t edit a deleted message. |
maybe the backend could handle it as a message deletion if an empty message is sent as "edited message" |
It's noted in the API ticket and we will block it. |
Just want to get the base in soon, so frontend and mobile can start working on the normal cases first, before handling edge cases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Base functionality working as expected 👍
☑️ Resolves
🛠️ API Checklist
🚧 Tasks
🏁 Checklist
docs/
has been updated