Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chat): API specs for "Edit message" #11207

Merged
merged 5 commits into from
Jan 11, 2024

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Dec 12, 2023

☑️ Resolves

🛠️ API Checklist

🚧 Tasks

  • System message hidden like with delete
    • Implement
  • Time limitation like for delete?
    • Limit editing to X hours (draft 24 hours, check what others do and discuss again)
  • What about bots?
    • Can not edit bot messages, moderators can
    • If a message triggered a bot already it's yolo and will not be retriggered with the new content automatically (bot can do based on the system message?)

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included
  • 📘 API documentation in docs/ has been updated

@nickvergessen nickvergessen added 2. developing enhancement feature: chat 💬 Chat and system messages feature: api 🛠️ OCS API for conversations, chats and participants labels Dec 12, 2023
@nickvergessen nickvergessen self-assigned this Dec 12, 2023
@nickvergessen nickvergessen mentioned this pull request Dec 12, 2023
18 tasks
@SystemKeeper

This comment was marked as outdated.

@nickvergessen nickvergessen force-pushed the feat/11206/edit-message-API branch from 8740f9d to b8edaca Compare December 13, 2023 14:19
@SystemKeeper
Copy link
Contributor

Maybe it’s obvious, but:

  • Make sure editing of captions for shared files work as well

?

@nickvergessen
Copy link
Member Author

As per overview

  • Don't allow changing from message to caption and vice-versa

But yeah will have to be handled explicitly not sure where I dropped it when copying over

@nickvergessen nickvergessen force-pushed the feat/11206/edit-message-API branch from b1e5614 to 35e51d5 Compare December 19, 2023 13:38
@SystemKeeper
Copy link
Contributor

The lastMessage object on the room list does not include the new lastEdit* properties:

Bildschirmfoto 2024-01-07 um 19 18 41 Bildschirmfoto 2024-01-07 um 19 19 12

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the feat/11206/edit-message-API branch from 9631669 to 74283ad Compare January 10, 2024 12:08
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member Author

The lastMessage object on the room list does not include the new lastEdit* properties:

Fixed

@SystemKeeper
Copy link
Contributor

API allows to edit a message to an empty message.

@DorraJaouad
Copy link
Contributor

API allows to edit a message to an empty message.

I think this leads the edit to act like deleting the message ?

@SystemKeeper
Copy link
Contributor

Not at the moment at least, right now it’s just an edited, empty message. I don’t think it should act as deleted personally, because you can’t edit a deleted message.

@Ivansss
Copy link
Member

Ivansss commented Jan 10, 2024

maybe the backend could handle it as a message deletion if an empty message is sent as "edited message"

@nickvergessen
Copy link
Member Author

API allows to edit a message to an empty message.

It's noted in the API ticket and we will block it.

@nickvergessen
Copy link
Member Author

Just want to get the base in soon, so frontend and mobile can start working on the normal cases first, before handling edge cases

Copy link
Member

@Ivansss Ivansss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Base functionality working as expected 👍

@nickvergessen nickvergessen merged commit 4ad0823 into main Jan 11, 2024
53 checks passed
@nickvergessen nickvergessen deleted the feat/11206/edit-message-API branch January 11, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review enhancement feature: api 🛠️ OCS API for conversations, chats and participants feature: chat 💬 Chat and system messages
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

✏️ Edit message - API
4 participants