Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Message): optimize getters and provided props #11349

Merged
merged 4 commits into from
Jan 11, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jan 8, 2024

☑️ Resolves

  • Delete unused scrollerBoundingClientRect prop
  • Move computation of isLastCallStartedMessage to store
  • Make update of hasCall more clear across the app
    • Prevent notifications from updating store if already done

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

No visual changes

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • ⛑️ Tests are included or not possible

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added this to the 💞 Following Major (29) milestone Jan 8, 2024
@Antreesy Antreesy requested a review from DorraJaouad January 8, 2024 13:04
@Antreesy Antreesy self-assigned this Jan 8, 2024
@Antreesy Antreesy force-pushed the fix/noid/remove-provide branch 2 times, most recently from c0e60b1 to 578341f Compare January 8, 2024 14:03
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
…d information

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/noid/remove-provide branch from 578341f to b6d593d Compare January 10, 2024 14:26
@Antreesy Antreesy requested a review from DorraJaouad January 10, 2024 14:28
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested 🟢

@Antreesy Antreesy merged commit ee30cc5 into main Jan 11, 2024
36 checks passed
@Antreesy Antreesy deleted the fix/noid/remove-provide branch January 11, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants