Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(BreakoutRoomsEditor): Add amount validation #11366

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

DorraJaouad
Copy link
Contributor

☑️ Resolves

Hint is conditioned because the user will likely pick an amount from 1 to 20, but it will be shown in case they attempt to choose outside that range.

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🚧 Tasks

  • Code review
  • Visual review

🏁 Checklist

Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After checking the upstream code, it now make a little sense for me to literally upstream it 😬

We still could do at the place (with refs and without pure JS) but to expose checkValidity() from lib is not as needed as to expose focus(), for example.
In addition to that, NcInput is simple visual / low-functional component, so again, I don't see any point in making it more complicate upstream

Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad force-pushed the fix/11355/breakout-rooms-amount branch from 4a77f3e to 6a92df3 Compare January 16, 2024 13:07
@DorraJaouad DorraJaouad merged commit 0099cef into main Jan 18, 2024
36 checks passed
@DorraJaouad DorraJaouad deleted the fix/11355/breakout-rooms-amount branch January 18, 2024 14:51
@Antreesy
Copy link
Contributor

/backport to stable28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect handling of invalid breakout rooms number
3 participants