Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(breakout): stop breakout rooms on removing #11396

Merged
merged 2 commits into from
Jan 19, 2024
Merged

fix(breakout): stop breakout rooms on removing #11396

merged 2 commits into from
Jan 19, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jan 17, 2024 •
edited by nickvergessen
Loading

☑️ Resolves

  • API part is splitted out from enh(participants): extract and reuse patchParticipants action #11394
  • When removing breakout rooms, status at parent is now reset (if create rooms again, they will not be marked as started)
  • Updating lastActivity when requesting / dismissing the assistance allows moderators to re-fetch breakout rooms within 30s interval (?modifiedSince) and actually see the request (before it was once in 10 requests on a full fetch)

🛠️ API Checklist

🚧 Tasks

  • Write tests

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@Antreesy Antreesy added this to the 💞 Next Major (29) milestone Jan 17, 2024
@nickvergessen
Copy link
Member

/backport to stable28

@nickvergessen nickvergessen force-pushed the fix/noid/stop-breakout-rooms-on-remove branch from 248ec87 to a68788a Compare January 18, 2024 11:57
@nickvergessen nickvergessen marked this pull request as ready for review January 18, 2024 11:57
@Antreesy
Copy link
Contributor Author

Tested against frontend 🟢

@Antreesy Antreesy enabled auto-merge January 18, 2024 12:17
@Antreesy
Copy link
Contributor Author

Antreesy commented Jan 18, 2024 •
edited
Loading

As something needs to be patched, could we additionaly make sure, that all methods:

  • startBreakoutRooms
  • stopBreakoutRooms
  • removeBreakoutRooms

also update lastActivity for the given room?
Note: these changes require a conversation update on non-actor side, which happens once in 5 minutes without lastActivity update (otherwise only 30 seconds)

@Antreesy Antreesy mentioned this pull request Jan 19, 2024
Merged
2 tasks
Antreesy and others added 2 commits January 19, 2024 14:56
@Antreesy @nickvergessen
fix(breakout): stop breakout rooms when removing, update lastActivity…
5751ab8 
… when request / dismiss assistance

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@nickvergessen
fix(breakout): Add integration test for reseting the breakout status …
7dfdcb4 
…on the parent

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the fix/noid/stop-breakout-rooms-on-remove branch from a68788a to 7dfdcb4 Compare January 19, 2024 13:57
@Antreesy Antreesy merged commit 6d6ed01 into main Jan 19, 2024
53 checks passed
@Antreesy Antreesy deleted the fix/noid/stop-breakout-rooms-on-remove branch January 19, 2024 14:21
@backportbot backportbot bot mentioned this pull request Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

Assignees

@nickvergessen nickvergessen

@Antreesy Antreesy

Labels
3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: breakout rooms 🖖
Projects
None yet
Milestone
v19.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Antreesy @nickvergessen