Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Document empty display names #11410

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jan 19, 2024

☑️ Resolves

🛠️ API Checklist

🚧 Tasks

  • Write test for deleted user
  • Write test for display name
  • Document empty display name on actor type deleted_users

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added 3. to review bug feature: chat 💬 Chat and system messages feature: api 🛠️ OCS API for conversations, chats and participants labels Jan 19, 2024
@nickvergessen nickvergessen added this to the 💞 Next Major (29) milestone Jan 19, 2024
@nickvergessen nickvergessen self-assigned this Jan 19, 2024
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/noid/document-empty-displayname branch from 4d20cc5 to 0e2cafc Compare January 19, 2024 15:23
@nickvergessen nickvergessen merged commit 0c7ed67 into main Jan 22, 2024
53 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/document-empty-displayname branch January 22, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: chat 💬 Chat and system messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants