feat(TopBar): show description during call

[DorraJaouad]

☑️ Resolves

• Fix Conversation description not shown during call #10562

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before	🏡 After

🚧 Tasks

• Design review

🏁 Checklist

• 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
• 🖌️ Design was reviewed, approved or inspired by the design team
• ⛑️ Tests are included or not possible
• 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

[Antreesy]

Was introduced here: e7f3388
So I'd ask @marcoambrosini , why it has been done back then?

[marcoambrosini]

So I'd ask @marcoambrosini , why it has been done back then?

It was done to minimize information that was not crucial during a call. Actually @jancborchardt back then you were in favor of reducing text in the call view. We didn't even have the name and avatar, and it took me quite some convincing effort to add it there :)
Also, as far as I can remember, no call view from other apps shows conversation or meeting description while in the call.

[nickvergessen]

We didn't add it because we wanted to put information like "people in call", "call duration", etc. there, but they are now in another place, so we can show the description there now.

[marcoambrosini]

We didn't add it because we wanted to put information like "people in call", "call duration", etc.

Nope, that proposal came later on, avatar and name were there before call time and participant count were added.

[jancborchardt]

@DorraJaouad nice! Just one thing: It looks like the text doesn’t have enough contrast, since it’s color-text-maxcontrast which is intended to be used on a light background but it’s used on dark. Either:

• Is is possible to invoke the dark-theme color-text-maxcontrast for the subline here?
• Or we use color-main-text for the subline here too, when in a call

@marcoambrosini Whatever was discussed in the past, most recent consensus was to add the description in the subline, same as how it is in the chat and as per the issue: #10562

[nickvergessen]

Is is possible to invoke the dark-theme color-text-maxcontrast for the subline here?

spreed/src/components/TopBar/TopBar.vue

Line 501 in c74c6f1

color: var(--color-text-lighter);

[Antreesy]

Looks brighter (#999999) with the dark-theme locally applied:

(new -> old)

[jancborchardt]

Is is possible to invoke the dark-theme color-text-maxcontrast for the subline here?

spreed/src/components/TopBar/TopBar.vue

Line 501 in c74c6f1

color: var(--color-text-lighter);

This is a deprecated variable though. Only text colors we should use are color-main-text and color-text-maxcontrast as per design guidelines: https://docs.nextcloud.com/server/latest/developer_manual/design/foundations.html#text-color

I'd say for simplicity and to make sure the contrast works, let's use color-main-text for the subline here too.

---

@Antreesy yes, the contrast works with dark theme enabled because the color-text-maxcontrast changes shade slightly. This is why I suggested:

Is it possible to invoke the dark-theme color-text-maxcontrast for the subline here?

[Antreesy]

This is a deprecated variable though

Then we should also migrate to color-text-maxcontrast in some places.
For the color-main-text for a description, I can't see, why not. Conversation name is bold, so would be distinguishable enough

[DorraJaouad]

let's use color-main-text for the subline here too.

It conveyed 'too much' contrast to me so I opted for the dark theme color-text-maxcontrast

But I set it to color-main-text as suggested

[jancborchardt]

Looks good according to screenshots, and thanks for the deprecated variable fixes! :)

[DorraJaouad]

Rebased onto master

[marcoambrosini]

Can we at least go back to fading things out after some mouse inactivity?