Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(LocalVideo): Show self talking indicator #11429

Merged
merged 1 commit into from
Jan 23, 2024
Merged

feat(LocalVideo): Show self talking indicator #11429

merged 1 commit into from
Jan 23, 2024

Conversation

DorraJaouad
Copy link
Contributor

☑️ Resolves

Summary:

  • Added speaking class to local video
  • Slight improvement in Video component but with no visual changes.

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

Talking indicator is now shown on local video just like other participants videos

Recording.2024-01-23.112246.mp4

🚧 Tasks

  • Code review

🏁 Checklist

@DorraJaouad
feat(LocalVideo): show self talking indicator
e17ff31 
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad added this to the 💞 Next Major (29) milestone Jan 23, 2024
@DorraJaouad DorraJaouad requested a review from Antreesy January 23, 2024 10:26
@DorraJaouad DorraJaouad self-assigned this Jan 23, 2024
Antreesy
Antreesy approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!
Tested for local video, remote video and screenshare with presenter view

@DorraJaouad DorraJaouad merged commit 697f06c into main Jan 23, 2024
36 checks passed
@DorraJaouad DorraJaouad deleted the feat/10563/talking-border-indicator branch January 23, 2024 12:50
jancborchardt
jancborchardt approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice fix, makes it more understandable :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@jancborchardt jancborchardt jancborchardt approved these changes

Assignees

@DorraJaouad DorraJaouad

Labels
3. to review enhancement feature: call 📹 Voice and video calls
Projects
None yet
Milestone
v19.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

Own video does not show talking indicator
3 participants
@DorraJaouad @jancborchardt @Antreesy