-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Poll): live polls pop-ups during the call #11448
Conversation
cc @nextcloud/designers for the input on NC29 feature |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that blocking the whole UI like this something we want to do. Joas suggested to make polls more visible in the issue, and I think that's a better solution. Dialogs that block the whole interface should only be shown when triggered by the user.
I will add this to my tasks and come up with a quick mockup soon :)
What do you think of using a toast message, @marcoambrosini ? Seems less invasive |
Sounds good for when the chat is closed. But I would still color the system message in the chat view itself |
822d579
to
867df43
Compare
src/components/MessagesList/MessagesGroup/Message/MessagePart/MessageBody.vue
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested. Nothing is blocking
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
f721135
to
ae19ca8
Compare
☑️ Resolves
<Poll />
(card/button), to be shown as message part<PollViewer />
(dialog), detached and moved up on the<ChatView />
and<CallView />
level🖌️ UI Checklist
🖼️ Screenshots / Screencasts
Toast message:
Unvoted poll highlight:
Talk Main, call view:
Files sidebar (same appearance as with open chat, public share sidebars):
live-polls-upd.mp4
🚧 Tasks
🏁 Checklist