Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Poll): live polls pop-ups during the call #11448

Merged
merged 5 commits into from
Feb 21, 2024
Merged

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jan 25, 2024

☑️ Resolves

  • Fix Make polls more visible when "live" #11372
  • Poll component is splitted into two:
    • <Poll /> (card/button), to be shown as message part
    • <PollViewer /> (dialog), detached and moved up on the <ChatView /> and <CallView /> level
    • With newly processed messages, dialog is triggered to be open when participant is in call
    • Necessary evil: components code is optimized

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

Toast message:
image
Unvoted poll highlight:
image

Talk Main, call view:
Files sidebar (same appearance as with open chat, public share sidebars):

live-polls-upd.mp4

🚧 Tasks

  • Follow-ups:
    • migrate pollsStore 🍍

🏁 Checklist

src/components/PollViewer/PollViewer.vue Outdated Show resolved Hide resolved
src/components/PollViewer/PollViewer.vue Outdated Show resolved Hide resolved
src/views/MainView.vue Show resolved Hide resolved
@Antreesy
Copy link
Contributor Author

cc @nextcloud/designers for the input on NC29 feature

Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that blocking the whole UI like this something we want to do. Joas suggested to make polls more visible in the issue, and I think that's a better solution. Dialogs that block the whole interface should only be shown when triggered by the user.

I will add this to my tasks and come up with a quick mockup soon :)

@marcoambrosini marcoambrosini self-assigned this Jan 29, 2024
@Antreesy Antreesy marked this pull request as draft January 29, 2024 13:46
@Antreesy
Copy link
Contributor Author

Antreesy commented Feb 9, 2024

What do you think of using a toast message, @marcoambrosini ? Seems less invasive

image

@nickvergessen
Copy link
Member

What do you think of using a toast message

Sounds good for when the chat is closed.

But I would still color the system message in the chat view itself

@Antreesy Antreesy force-pushed the feat/11372/live-polls branch 2 times, most recently from 822d579 to 867df43 Compare February 12, 2024 16:18
@Antreesy Antreesy marked this pull request as ready for review February 16, 2024 11:31
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Nothing is blocking

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy merged commit 22848f4 into main Feb 21, 2024
45 checks passed
@Antreesy Antreesy deleted the feat/11372/live-polls branch February 21, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make polls more visible when "live"
4 participants