-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ConversationIcon): highlight public conversations #11450
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should avoid adding this information on the avatar @Antreesy
Let me think about this and will come up with an alternative proposal soon.
This comment was marked as resolved.
This comment was marked as resolved.
4536a7e
to
39d68d1
Compare
Rebased and updated screenshots. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-wise, it's fine ✅
We can keep the same icon for federated conversations or it should be changed for some reason ?
I think it would be nice info @Antreesy , shouldn't overwhelm much |
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
39d68d1
to
cb774ad
Compare
@Antreesy could we use the same color as the title for those icons? |
This would differ from the default color (which was picked for the component in the library), so we kept it as-is for now |
☑️ Resolves
Conversation (NcListItem) now indicates, if conversation is public (available for guests by link)
Place is details above the unread counter
To discuss:
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
--color-primary-element-text
for active--color-text-maxcontrast
for others🏁 Checklist