Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tests): Add coverage from integration tests #11487

Closed
wants to merge 2 commits into from

Conversation

nickvergessen
Copy link
Member

☑️ Resolves

  • Fix #…

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
B A

🚧 Tasks

  • ...
  • ...

🏁 Checklist


🛠️ API Checklist

🚧 Tasks

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

Signed-off-by: Joas Schilling <coding@schilljs.com>
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e9b7a39) 25.81% compared to head (7377186) 25.81%.
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #11487   +/-   ##
=========================================
  Coverage     25.81%   25.81%           
  Complexity      356      356           
=========================================
  Files             8        8           
  Lines          1383     1383           
=========================================
  Hits            357      357           
  Misses         1026     1026           
Flag Coverage Δ
phpunit 25.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member Author

Hmm it seems to cover the code of the test, not the API calls we do, so this renders it a bit useless for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant