Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(federation)!: Add room name to invite and fix casing of properties #11505

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

nickvergessen
Copy link
Member

☑️ Resolves

🛠️ API Checklist

🚧 Tasks

  • Add room name and document state
  • Change from _ casing to camelCase like on all other APIs

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen added 3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: federation 🌐 labels Feb 1, 2024
@nickvergessen nickvergessen added this to the 💞 Next Major (29) milestone Feb 1, 2024
@nickvergessen nickvergessen self-assigned this Feb 1, 2024
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/11278/add-room-name-to-invitation branch from 86b2bf3 to e96b356 Compare February 1, 2024 07:56
@SystemKeeper
Copy link
Contributor

Just by looking at the code, it is correct that jsonSerialize does not contain roomName?

@SystemKeeper
Copy link
Contributor

Not related to this PR but tests show

[4131] [Thu Feb  1 07:58:31 2024] {"app":"PHP","message":"Undefined array key \"silent\" at \/home\/runner\/work\/spreed\/spreed\/apps\/spreed\/lib\/Model\/Message.php#224"}

@nickvergessen
Copy link
Member Author

Just by looking at the code, it is correct that jsonSerialize does not contain roomName?

It can not, as that is not stored in the invitation table

Copy link
Contributor

@SystemKeeper SystemKeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works

@nickvergessen nickvergessen merged commit 1ae1017 into main Feb 1, 2024
53 checks passed
@nickvergessen nickvergessen deleted the bugfix/11278/add-room-name-to-invitation branch February 1, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: federation 🌐
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants