Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(federation): chatting prerequisite #11517

Merged
merged 4 commits into from
Feb 5, 2024
Merged

chore(federation): chatting prerequisite #11517

merged 4 commits into from
Feb 5, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Feb 2, 2024 •
edited
Loading

☑️ Resolves

  • Splitted less related things from feat(federation): chat functionality for remote server #11383, as its growing too much
    • Add entry for RightSidebar to add remote participants without OCS_API_VIEWER
    • Add icon to indicate federated conversations
    • move editMessage to messagesStore
    • patch messagesService, so all could accept options for generateOcsUrl and axios

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏡 After
image
image

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • ⛑️ Tests are included or not possible

@Antreesy
feat(federation): show icon in LeftSidebar next to the federated conv…
befea25 
…ersations

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added this to the 💞 Next Major (29) milestone Feb 2, 2024
@Antreesy Antreesy self-assigned this Feb 2, 2024
@Antreesy Antreesy requested a review from DorraJaouad February 5, 2024 07:50
DorraJaouad
DorraJaouad reviewed Feb 5, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the changes were made in #11383
Are you planning to split them and revert in the other PR ?

Never mind XD

DorraJaouad
DorraJaouad reviewed Feb 5, 2024
View reviewed changes
src/components/NewMessage/NewMessage.vue Outdated Show resolved Hide resolved
src/store/messagesStore.js Show resolved Hide resolved
@Antreesy
chore(messages): create editMessage action in the store
64ab1be 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
feat(federation): patch messageService to accept remote credentials
78a2fd1 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
debug: allow to add remote users via frontend
8c664fe 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the feat/11273/chatting-prerequisite branch from 02619e8 to 8c664fe Compare February 5, 2024 10:50
DorraJaouad
DorraJaouad approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

@Antreesy Antreesy enabled auto-merge February 5, 2024 10:56
@Antreesy Antreesy merged commit 6e12a09 into main Feb 5, 2024
36 checks passed
@Antreesy Antreesy deleted the feat/11273/chatting-prerequisite branch February 5, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@Antreesy Antreesy

Labels
3. to review feature: federation 🌐 feature: frontend 🖌️ "Web UI" client technical debt
Projects
None yet
Milestone
v19.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Antreesy @DorraJaouad