Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Federation): list pending invitations #11535

Merged
merged 3 commits into from
Feb 21, 2024
Merged

feat(Federation): list pending invitations #11535

merged 3 commits into from
Feb 21, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Feb 5, 2024 •
edited
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

image
image

🚧 Tasks

Design review:

  • It could look like a list item "Pending invitations" as the first item in the conversation list with the MDI icon `account-mutiple-plus`
  • Modal view: Accept button should have text "[checkmark icon] Accept"
  • Modal heading can have a subline explaining that it - check wording:
    Join conversations from remote Nextcloud servers
  • Subline in each item "from Alice Smith at nextcloud.local", no "Invitation from"
  • Hide item in conversation list if there are no pending invitations

🏁 Checklist

@Antreesy Antreesy added this to the 💞 Next Major (29) milestone Feb 5, 2024
@Antreesy Antreesy self-assigned this Feb 5, 2024
@Antreesy Antreesy changed the base branch from main to feat/11273/chatting-prerequisite February 5, 2024 10:58
@Antreesy Antreesy force-pushed the feat/11279/list-invitations branch from 51bfdf4 to daabbd4 Compare February 5, 2024 11:00
Base automatically changed from feat/11273/chatting-prerequisite to main February 5, 2024 13:15
@Antreesy Antreesy force-pushed the feat/11279/list-invitations branch from daabbd4 to da526f0 Compare February 5, 2024 14:17
@Antreesy Antreesy requested a review from DorraJaouad February 7, 2024 14:08
@Antreesy Antreesy force-pushed the feat/11279/list-invitations branch from da526f0 to 1bb4b39 Compare February 7, 2024 14:09
@Antreesy Antreesy requested a review from nimishavijay February 7, 2024 14:09
@Antreesy Antreesy marked this pull request as ready for review February 7, 2024 14:09
@Antreesy Antreesy force-pushed the feat/11279/list-invitations branch 3 times, most recently from 1f2ed57 to c36d24c Compare February 9, 2024 09:59
@Antreesy Antreesy marked this pull request as draft February 12, 2024 15:40
@Antreesy Antreesy changed the base branch from main to bugfix/11278/add-inviter-info-to-invitation-list February 14, 2024 08:34
@Antreesy Antreesy force-pushed the feat/11279/list-invitations branch from c36d24c to e344c84 Compare February 14, 2024 08:35
Base automatically changed from bugfix/11278/add-inviter-info-to-invitation-list to main February 14, 2024 08:39
@Antreesy Antreesy force-pushed the feat/11279/list-invitations branch from e344c84 to 3fe62cf Compare February 14, 2024 09:23
@Antreesy Antreesy marked this pull request as ready for review February 16, 2024 11:30
DorraJaouad
DorraJaouad reviewed Feb 16, 2024
View reviewed changes
src/stores/federation.js Show resolved Hide resolved
src/stores/federation.js Outdated Show resolved Hide resolved
src/components/LeftSidebar/LeftSidebar.vue Show resolved Hide resolved
@Antreesy Antreesy force-pushed the feat/11279/list-invitations branch from b4d87a9 to 7486bb3 Compare February 19, 2024 11:59
DorraJaouad
DorraJaouad reviewed Feb 20, 2024
View reviewed changes
src/stores/federation.js Outdated Show resolved Hide resolved
src/components/LeftSidebar/InvitationHandler.vue Show resolved Hide resolved
src/stores/federation.js Outdated Show resolved Hide resolved
DorraJaouad
DorraJaouad approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦅

@Antreesy
chore(LeftSidebar): minor fixes
69d7915 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
feat(federation): manage invitations through the store
1cd6f9b 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
feat(federation): introduce invitations inbox dialog
f4c7fd9 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the feat/11279/list-invitations branch from 050ea8c to f4c7fd9 Compare February 21, 2024 08:29
@Antreesy Antreesy enabled auto-merge February 21, 2024 08:30
@Antreesy Antreesy merged commit 2833efc into main Feb 21, 2024
45 checks passed
@Antreesy Antreesy deleted the feat/11279/list-invitations branch February 21, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

Assignees

@Antreesy Antreesy

Labels
2. developing enhancement feature: federation 🌐 feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
v19.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
3 participants
@Antreesy @nickvergessen @DorraJaouad