Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icons): migrate conversation avatars to MDI icons #11542

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Feb 6, 2024

☑️ Resolves

  • Move avatar icons to MDI appearance
  • Fix contrast for the light theme

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🖼️ Making the light theme contrast

#999999 and #6B6B6B aligned with var(--color-text-maxcontrast)

🏚️ Before 🏡 After
image image
image image

🖼️ Switch to material design icons

🏚️ Before 🏡 After 🏚️ Before 🏡 After
Group Group Public Public
image image image image
Mail Mail Password Password
image image image image
Phone Phone File File
image image image image
User User
image image

🚧 Follow-up

  • Replace public icon with group icon -> add "status-like" icon for indicating public conversations

🏁 Checklist

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New icons and colors look good to me now from design perspective :)
(didnt review the code and didnt test)

@Antreesy Antreesy force-pushed the fix/11450/move-icon branch from 74af004 to 4784662 Compare February 8, 2024 08:35
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/11450/move-icon branch from 4784662 to dce7984 Compare February 21, 2024 12:07
@Antreesy Antreesy merged commit 128b9df into main Feb 22, 2024
64 checks passed
@Antreesy Antreesy deleted the fix/11450/move-icon branch February 22, 2024 15:35
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Antreesy good icon changes! One thing – after trying it out a bit more, it feels like the color scheme for the placeholders would look better the other way around between dark and light mode – with the new and better contrasting colors of course:

  • Light mode: Light background and dark icon
  • Dark mode: Dark background and light icon (as it was before)

Or was it switched around for specific reasons?

@Antreesy
Copy link
Contributor Author

Or was it switched around for specific reasons?

Was aligned with colors used at server apps (Files):
image
image

@jancborchardt
Copy link
Member

Ah right, and that was also for improved accessibility. All good then and thanks for the note @Antreesy! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants