-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(icons): migrate conversation avatars to MDI icons #11542
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New icons and colors look good to me now from design perspective :)
(didnt review the code and didnt test)
74af004
to
4784662
Compare
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
4784662
to
dce7984
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Antreesy good icon changes! One thing – after trying it out a bit more, it feels like the color scheme for the placeholders would look better the other way around between dark and light mode – with the new and better contrasting colors of course:
- Light mode: Light background and dark icon
- Dark mode: Dark background and light icon (as it was before)
Or was it switched around for specific reasons?
Ah right, and that was also for improved accessibility. All good then and thanks for the note @Antreesy! :) |
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🖼️ Making the light theme contrast
#999999
and#6B6B6B
aligned withvar(--color-text-maxcontrast)
🖼️ Switch to material design icons
🚧 Follow-up
🏁 Checklist