perf(sharing): Cache the list of tokens per user #11547
Draft
+24
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
3. to review
enhancement
feature: upload & shares & voice 📤🎙️
nickvergessen
force-pushed
the
perf/noid/cache-the-roomtokens-per-user
branch
from
847dd15 to
9eadb8a
Compare
nickvergessen
added
the
feature: api 🛠️
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
perf/noid/cache-the-roomtokens-per-user
branch
from
9eadb8a to
1847df7
Compare
nickvergessen
modified the milestones:
v19.0.0-beta.3,
💞 Next Beta (29),
v19.0.0-beta.4,
💙 Next Major (30)
nickvergessen
commented
Mar 27, 2024
| @@ -512,6 +514,9 @@ public function addUsers(Room $room, array $participants, ?IUser $addedBy = null | |||
| $this->attendeeMapper->delete($attendee); | |||
| throw new CannotReachRemoteException(); | |||
| } | |||
| } elseif ($attendee->getActorType() === Attendee::ACTOR_USERS) { | |||
| $cache = $this->cacheFactory->createDistributed('talk/usertokens'); | |||
There was a problem hiding this comment.
Should go into CachePrefix as a const
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ API Checklist
🏁 Checklist
docs/has been updated or is not required