Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(modal): mount nested modals inside global modals #11556

Merged
merged 2 commits into from
Feb 12, 2024
Merged

fix(modal): mount nested modals inside global modals #11556

merged 2 commits into from
Feb 12, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Feb 9, 2024 •
edited
Loading

☑️ Resolves

  • TODO: check NcDialog components and wrappers

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🏁 Checklist

@Antreesy Antreesy added this to the 💞 Next Major (29) milestone Feb 9, 2024
@Antreesy Antreesy requested a review from DorraJaouad February 9, 2024 09:27
@Antreesy Antreesy self-assigned this Feb 9, 2024
@Antreesy
Copy link
Contributor Author

Antreesy commented Feb 9, 2024

/backport to stable28

@Antreesy Antreesy force-pushed the fix/11543/fix-nested-modals branch from cc11819 to 654599e Compare February 12, 2024 09:16
DorraJaouad
DorraJaouad approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No other modal remaining ✅ .

@Antreesy
fix(modal): mount nested modals/dialogs inside global modals
c53ce93 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix(modal): add missing modal containers
b939b26 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/11543/fix-nested-modals branch from 75d4800 to b939b26 Compare February 12, 2024 12:03
@Antreesy Antreesy enabled auto-merge February 12, 2024 12:03
@Antreesy Antreesy merged commit 9dc0ff0 into main Feb 12, 2024
37 checks passed
@Antreesy Antreesy deleted the fix/11543/fix-nested-modals branch February 12, 2024 12:12
@backportbot backportbot bot mentioned this pull request Feb 12, 2024
Merged
@Antreesy
Copy link
Contributor Author

/backport to stable27

@backportbot backportbot bot mentioned this pull request Mar 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@Antreesy Antreesy

Labels
bug feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
v19.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

Conversation Setting, Advanced Permissions pop-up screen hidden
2 participants
@Antreesy @DorraJaouad