-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Plug-in talk specific filters for unified search #11575
Conversation
8208894
to
3fa926e
Compare
3fa926e
to
76f29cc
Compare
@Antreesy can you check for loader stuff so we don't generate the next topic for the performance hackweek 😅 |
0c0ff4d
to
97aa1b0
Compare
ea218d9
to
d599e15
Compare
fae3ff8
to
1870f2f
Compare
@Antreesy Not sure, can you just pull latest nextcloud/server#43189 and compile and try again? |
I am aware of this, that is why I left this question #11575 (comment) however you are right it is out of scope and we have to figure out why the backend does not respond correctly at the server level. cc: @Antreesy |
Signed-off-by: fenn-cs <fenn25.fn@gmail.com> Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
1870f2f
to
3e28511
Compare
Hello! I've rebased the PR and added some changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
Screencast.from.02-06-2024.11.27.48.AM.webm
🚧 Tasks
🏁 Checklist