Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Plug-in talk specific filters for unified search #11575

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

nfebe
Copy link
Contributor

@nfebe nfebe commented Feb 10, 2024

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

Filter Selector
image image
Screencast.from.02-06-2024.11.27.48.AM.webm

🚧 Tasks

  • ...
  • ...

🏁 Checklist

@nfebe nfebe force-pushed the 42914-search-in-single-talk-room branch 7 times, most recently from 8208894 to 3fa926e Compare February 12, 2024 16:15
@nfebe nfebe force-pushed the 42914-search-in-single-talk-room branch from 3fa926e to 76f29cc Compare February 12, 2024 22:20
src/search.js Outdated Show resolved Hide resolved
src/search.js Outdated Show resolved Hide resolved
src/search.js Outdated Show resolved Hide resolved
src/search.js Outdated Show resolved Hide resolved
@nickvergessen
Copy link
Member

@Antreesy can you check for loader stuff so we don't generate the next topic for the performance hackweek 😅

src/search.js Outdated Show resolved Hide resolved
src/search.js Outdated Show resolved Hide resolved
src/search.js Outdated Show resolved Hide resolved
lib/Search/UnifiedSearchFilterPlugin.php Outdated Show resolved Hide resolved
src/search.js Outdated Show resolved Hide resolved
src/components/RoomSelector.vue Outdated Show resolved Hide resolved
@nfebe nfebe force-pushed the 42914-search-in-single-talk-room branch 2 times, most recently from 0c0ff4d to 97aa1b0 Compare February 13, 2024 09:34
@nfebe nfebe mentioned this pull request Feb 13, 2024
7 tasks
src/search.js Outdated Show resolved Hide resolved
@nfebe nfebe marked this pull request as ready for review February 13, 2024 12:49
src/search.js Outdated Show resolved Hide resolved
@nfebe nfebe force-pushed the 42914-search-in-single-talk-room branch 2 times, most recently from ea218d9 to d599e15 Compare February 13, 2024 13:17
src/search.js Outdated Show resolved Hide resolved
src/search.js Outdated Show resolved Hide resolved
src/search.js Outdated Show resolved Hide resolved
src/search.js Show resolved Hide resolved
@nfebe nfebe force-pushed the 42914-search-in-single-talk-room branch 2 times, most recently from fae3ff8 to 1870f2f Compare February 14, 2024 23:31
@Antreesy
Copy link
Contributor

Couldn't get it rendered anymore:
image

Is there anything I'm mising to install on server/ API level?

Good job with dynamic import, btw. That's about collectives plugin size, so should be good for the current release
image

@nfebe
Copy link
Contributor Author

nfebe commented Feb 15, 2024

@Antreesy Not sure, can you just pull latest nextcloud/server#43189 and compile and try again?

@Antreesy
Copy link
Contributor

It helped, thanks. I see that it's working, but I'm not sure that it filters messages correctly (might be not a part of this PR, seems to be on server side). If you could confirm, I have nothing against this PR to be merged.

Chat 5 as current Selected Chat 5 No filters
image image image

@nfebe
Copy link
Contributor Author

nfebe commented Feb 15, 2024

I am aware of this, that is why I left this question #11575 (comment) however you are right it is out of scope and we have to figure out why the backend does not respond correctly at the server level.

cc: @Antreesy

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the 42914-search-in-single-talk-room branch from 1870f2f to 3e28511 Compare February 20, 2024 09:46
@Antreesy
Copy link
Contributor

Hello! I've rebased the PR and added some changes:

  • Updated RoomSelector design
  • Changed props
  • Changed output (whole conversation instead of token, no need to fetch it)
  • Fix icon in filters dropdown

cc @fenn-cs @DorraJaouad

Copy link
Contributor Author

@nfebe nfebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates LGTM

Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good
Thanks @fenn-cs @Antreesy

@nfebe nfebe merged commit 4a03865 into main Feb 20, 2024
64 checks passed
@nfebe nfebe deleted the 42914-search-in-single-talk-room branch February 20, 2024 10:38
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🔍🗨️ Unified Search in individual Talk room
4 participants