Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(federation): Add TalkV1 federation proxy for mentions #11587

Merged
merged 27 commits into from
Feb 23, 2024
Merged

feat(federation): Add TalkV1 federation proxy for mentions #11587

merged 27 commits into from
Feb 23, 2024

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Feb 14, 2024 •
edited
Loading

Decision is to proxy the requests on the own server,
so we can proxy other services (matrix coming to mind)
in the future and the clients still have to only talk to
their own server, to help with CSP and to reduce the efforts

🛠️ API Checklist

🚧 Tasks

Legend:

  • 🟥 Must have
  • 🟨 Should have
  • 🟩 Good to have
  • ⚫ Not for now
  • Avatar
    • getAvatar 🟨
    • getAvatarDark 🟨
    • uploadAvatar ⚫ Moderation is not supported in TalkV1
    • emojiAvatar ⚫ Moderation is not supported in TalkV1
    • deleteAvatar ⚫ Moderation is not supported in TalkV1
  • Chat
    • receiveMessages 🟥
    • sendMessage 🟥
    • deleteMessage 🟥
    • editMessage 🟥
    • getMessageContext 🟥
    • setReadMarker 🟥
    • setReminder 🟨
    • getReminder 🟨
    • deleteReminder 🟨
    • markUnread 🟨
    • mentions 🟨
    • shareObjectToChat 🟩
    • getObjectsSharedInRoomOverview 🟩
    • getObjectsSharedInRoom 🟩
    • clearHistory ⚫ Moderation is not supported in TalkV1
  • Room
    • getParticipants 🟥
    • 🆕 capabilities 🟥
    • setSessionState 🟨
    • …

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen marked this pull request as draft February 14, 2024 11:44
@nickvergessen nickvergessen force-pushed the feat/noid/mention-proxy-sample branch from 3192954 to 670019c Compare February 15, 2024 09:25
@nickvergessen nickvergessen changed the title Temp feat(federation): Add TalkV1 federation proxy for mentions Feb 15, 2024
nickvergessen
nickvergessen commented Feb 15, 2024
View reviewed changes
lib/Controller/ChatController.php Outdated Show resolved Hide resolved
lib/Federation/CloudFederationProviderTalk.php Outdated Show resolved Hide resolved
lib/Federation/Proxy/TalkV1/ChatService.php Outdated Show resolved Hide resolved
lib/Federation/Proxy/TalkV1/ChatService.php Outdated Show resolved Hide resolved
lib/Federation/Proxy/TalkV1/ChatService.php Outdated Show resolved Hide resolved
tests/integration/features/federation/chat.feature Show resolved Hide resolved
@nickvergessen nickvergessen self-assigned this Feb 15, 2024
@nickvergessen nickvergessen added 3. to review enhancement feature: chat 💬 Chat and system messages feature: api 🛠️ OCS API for conversations, chats and participants feature: federation 🌐 labels Feb 15, 2024
@nickvergessen nickvergessen added this to the 💞 Next Major (29) milestone Feb 15, 2024
@nickvergessen nickvergessen force-pushed the feat/noid/mention-proxy-sample branch 5 times, most recently from 6caf731 to 25a81fe Compare February 22, 2024 16:12
@nickvergessen nickvergessen mentioned this pull request Feb 23, 2024
Closed
@nickvergessen
feat(federation): Add TalkV1 federation proxy for mentions
74e7541 
Decision is to proxy the requests on the own server,
so we can proxy other services (matrix coming to mind)
in the future and the clients still have to only talk to
their own server, to help with CSP and to reduce the efforts

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
feat(chat): Autocomplete for mentions of federated users
9df9b0a 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(federation)!: Change source for federated users to match the acto…
12af533 
…r type

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(federation): Allow federated users to get the room name
5a105bc 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(federation)!: Deprecate Enviroment federation info in favor of au…
62dca38 
…thenticator

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(federation): Use authenticator all the time instead of duplicatin…
ef4351f 
…g it into the controller

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(federation): Translate federated users from the own instance to l…
a86b694 
…ocal users

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
feat(federation): Abstract away the proxying
b7fb617 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
feat(federation): Extract user converter
74c81c3 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(tests): Fix dependency injection to existing tests
0f84497 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
feat(federation): Proxy RoomController::getParticipants()
c1eaad1 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
feat(federation): Handle sending chat messages
b9c3a7f 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
feat(middleware): Allow to easily jump from the Attribute to the Midd…
bebbffa 
…leware

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
feat(middleware): Filter federation supported things on the middleware
78dd420 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
feat(federation): Support the avatar
9d3f685 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(federation): Return "422 Unprocessable Entity" when can not reach…
821f600 
… remote

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
feat(federation): Add endpoint to get (remote) capabilities of a conv…
61a9a21 
…ersation

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(federation): Log unexpected status codes
629253b 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(federation): Abstract away the OCS data access
3ff452a 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
feat(federation): Federate getting messages and the message context
7171a47 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
feat(federation): Allow editing and deleting for federated users
5662c98 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(federation): Also translate last editor handling
3249b65 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
test(federation): Add tests for basic chatting functionality
a4b3822 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(chat): Remove editor information on deletion
9e43683 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
chore: Regenerate OpenAPI
632560a 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the feat/noid/mention-proxy-sample branch from c40c550 to 632560a Compare February 23, 2024 13:33
@nickvergessen nickvergessen marked this pull request as ready for review February 23, 2024 13:34
@nickvergessen nickvergessen mentioned this pull request Feb 23, 2024
Closed
37 tasks
@nickvergessen
fix(federation): Handle expected client errors well
1c957e2 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(tests): Fix invitation integration test
6c2f9a1 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen merged commit cc6ea4a into main Feb 23, 2024
64 checks passed
@nickvergessen nickvergessen deleted the feat/noid/mention-proxy-sample branch February 23, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SystemKeeper SystemKeeper SystemKeeper approved these changes

Assignees

@nickvergessen nickvergessen

Labels
3. to review enhancement feature: api 🛠️ OCS API for conversations, chats and participants feature: chat 💬 Chat and system messages feature: federation 🌐
Projects
💬 Talk team
Archived in project
Milestone
v19.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @SystemKeeper