feat(federation): provide UI toggles in Admin settings for federation options #11594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antreesy
added
3. to review
feature: api 🛠️
| :disabled="loading" | ||
| type="switch" | ||
| @update:checked="saveFederationOnlyTrustedServersEnabled"> | ||
| {{ t('spreed', 'Allow only federation with trusted servers') }} |
There was a problem hiding this comment.
Suggested change
| {{ t('spreed', 'Allow only federation with trusted servers') }} | |
| {{ t('spreed', 'Allow federation with trusted servers only') }} |
🤔
There was a problem hiding this comment.
Or maybe even
Suggested change
| {{ t('spreed', 'Allow only federation with trusted servers') }} | |
| {{ t('spreed', 'Only allow federation with trusted servers') }} |
There was a problem hiding this comment.
Also in the option to enable federation it’s „Federation“ with a capital „F“. Guess we should keep it consistent either way
There was a problem hiding this comment.
I though of Federation as a feature in general, and federation as a single conversation.
Maybe Only allow to federate with trusted servers would be better here?
DorraJaouad
reviewed
Feb 19, 2024
DorraJaouad
approved these changes
Feb 20, 2024
… options Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
force-pushed
the
feat/11503/admin-settings-follow-up
branch
from
1e21d26 to
d45bd04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏁 Checklist
🛠️ API Checklist
🏁 Checklist
docs/has been updated or is not required