Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(draft chat input): Store input in browser storage #11634

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Feat(draft chat input): Store input in browser storage #11634

merged 1 commit into from
Mar 4, 2024

Conversation

DorraJaouad
Copy link
Contributor

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

No visual changes.

🚧 Tasks

  • Code review

🏁 Checklist

@DorraJaouad DorraJaouad added this to the 💞 Next Major (29) milestone Feb 22, 2024
@DorraJaouad DorraJaouad requested a review from Antreesy February 22, 2024 11:56
@DorraJaouad DorraJaouad self-assigned this Feb 22, 2024
Antreesy
Antreesy reviewed Feb 23, 2024
View reviewed changes
src/components/NewMessage/NewMessage.vue Outdated Show resolved Hide resolved
src/components/NewMessage/NewMessage.vue Outdated Show resolved Hide resolved
src/stores/chatExtras.js Show resolved Hide resolved
@DorraJaouad DorraJaouad force-pushed the feat/3055/store-draft-messages-in-browser branch 2 times, most recently from d6a4cdf to 69fc318 Compare February 28, 2024 08:13
Antreesy
Antreesy reviewed Feb 28, 2024
View reviewed changes
src/stores/chatExtras.js Show resolved Hide resolved
src/components/NewMessage/NewMessage.vue Outdated Show resolved Hide resolved
src/components/NewMessage/NewMessage.vue Outdated Show resolved Hide resolved
src/stores/chatExtras.js Outdated Show resolved Hide resolved
@DorraJaouad DorraJaouad force-pushed the feat/3055/store-draft-messages-in-browser branch from 69fc318 to 4c0e6f6 Compare February 29, 2024 06:40
@DorraJaouad @Antreesy
Feat: Store input in browser storage
9efb614 
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the feat/3055/store-draft-messages-in-browser branch from 4c0e6f6 to 9efb614 Compare March 4, 2024 09:27
Antreesy
Antreesy approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased onto main
Reverted changes for removeParentIdToReply, as breaking replies
Tested with switching, reloading, editing, replies

@Antreesy Antreesy merged commit 82d5ea9 into main Mar 4, 2024
45 checks passed
@Antreesy Antreesy deleted the feat/3055/store-draft-messages-in-browser branch March 4, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

Assignees

@DorraJaouad DorraJaouad

Labels
enhancement feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
v19.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

Unsent message gets lost when accidentally closing tab
2 participants
@DorraJaouad @Antreesy