Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(InvitationHandler): adjust labels and icon appearance #11635

Merged
merged 1 commit into from
Feb 22, 2024
Merged

fix(InvitationHandler): adjust labels and icon appearance #11635

merged 1 commit into from
Feb 22, 2024

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

  • Minor fixes in styles and a11y:
    • text as variable (aria-label, title)
    • padding between icon - text
    • icon as dummy conversation (for MDI, not server source)

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image
image image

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences

@Antreesy
fix(InvitationHandler): adjust labels and icon appearance
5bdc7fa 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added this to the 💞 Next Major (29) milestone Feb 22, 2024
@Antreesy Antreesy requested a review from DorraJaouad February 22, 2024 15:47
@Antreesy Antreesy self-assigned this Feb 22, 2024
@Antreesy Antreesy merged commit ef784ea into main Feb 22, 2024
45 checks passed
@Antreesy Antreesy deleted the fix/noid/fix-invitation-dialog branch February 22, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees

@Antreesy Antreesy

Labels
3. to review bug feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
v19.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Antreesy @nickvergessen