Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(openapi): convert openapi to types and use in project #11652

Merged
merged 4 commits into from
Feb 29, 2024

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

  • Allow to use types/endpoints introduced with OpenAPI earlier

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

image

🚧 Tasks

  • Check other IDE (VSCode)
  • Code review

Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Option 'allowImportingTsExtensions' can only be used when either 'noEmit' or 'emitDeclarationOnly' is set.ts

"allowImportingTsExtensions": true,

.eslintrc.js Show resolved Hide resolved
src/components/ConversationSettings/BotsSettings.vue Outdated Show resolved Hide resolved
src/components/AdminSettings/BotsSettings.vue Outdated Show resolved Hide resolved
@Antreesy Antreesy force-pushed the feat/noid/openapi-to-typescript branch from 82d8a7c to d9cdd73 Compare February 27, 2024 14:09
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the feat/noid/openapi-to-typescript branch from d9cdd73 to 9c8539f Compare February 27, 2024 16:00
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for now

@Antreesy Antreesy merged commit 677147e into main Feb 29, 2024
45 checks passed
@Antreesy Antreesy deleted the feat/noid/openapi-to-typescript branch February 29, 2024 07:57
Comment on lines -10 to -15
"module": "ESNext",
"moduleResolution": "bundler",
"verbatimModuleSyntax": true,
"target": "ES2020",
"esModuleInterop": true,
"forceConsistentCasingInFileNames": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was wrong here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

covered by default config: "extends": "@vue/tsconfig/tsconfig.json"

Also we rolback and disabled checking for .vue files later, as it keep complaining on Windows + VSCode. Please check from your side, if there is something we've done wrong, when you have time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants