Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore label of data channel when processing received messages. #11660

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Ignore label of data channel when processing received messages. #11660

merged 1 commit into from
Feb 27, 2024

Conversation

fancycode
Copy link
Member

This is necessary for support of Janus 1.x which will use the (random) id of the publisher that sent the message as label.

☑️ Resolves

Testing

  • Setup HPB with Janux 1.x without this PR
  • Notice "talking" indication is not working in the browser
  • Apply changes from this PR
  • Reload and restart call
  • "talking" indication is working again

@Ivansss @SystemKeeper @mahibi FYI for the mobile apps.

@SystemKeeper SystemKeeper mentioned this pull request Feb 27, 2024
Merged
@nickvergessen nickvergessen added 3. to review enhancement feature: signaling 📶 Internal and external signaling backends labels Feb 27, 2024
@nickvergessen nickvergessen added this to the 💞 Next Major (29) milestone Feb 27, 2024
@fancycode
feat(webrtc): Ignore label of data channel when processing messages.
3c63095 
This is necessary for support of Janus 1.x which will use the
(random) id of the publisher that sent the message as label.

Signed-off-by: Joachim Bauch <bauch@struktur.de>
@fancycode fancycode force-pushed the ignore-datachannel-labels branch from dd2ab2b to 3c63095 Compare February 27, 2024 15:49
@fancycode fancycode added feature: WebRTC 🚡 WebRTC connection between browsers and/or mobile clients feature: SFU & SIP ☎️ and removed feature: signaling 📶 Internal and external signaling backends labels Feb 27, 2024
@mahibi mahibi mentioned this pull request Feb 27, 2024
Merged
5 tasks
Antreesy
Antreesy approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK code-wise

@nickvergessen nickvergessen merged commit 24a8251 into main Feb 27, 2024
45 checks passed
@nickvergessen nickvergessen deleted the ignore-datachannel-labels branch February 27, 2024 21:18
@fancycode
Copy link
Member Author

Would be nice if you could backport this so we can update Janus at some point and don't have to wait for customers to upgrade to newer versions of NC / Talk.

@nickvergessen
Copy link
Member

/backport to stable28

@nickvergessen
Copy link
Member

/backport to stable27

@backportbot backportbot bot mentioned this pull request Feb 28, 2024
Merged
@nickvergessen
Copy link
Member

/backport to stable26

@backportbot backportbot bot mentioned this pull request Feb 28, 2024
Merged
@backportbot backportbot bot mentioned this pull request Feb 28, 2024
Merged
2 tasks
@fancycode
Copy link
Member Author

Thanks for the backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees
No one assigned
Labels
3. to review enhancement feature: SFU & SIP ☎️ feature: WebRTC 🚡 WebRTC connection between browsers and/or mobile clients
Projects
None yet
Milestone
v19.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

Janus 1.x compatibility problem
3 participants
@fancycode @nickvergessen @Antreesy