Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(BrowserStorage): remember silent call / message per conversation #11719

Merged
merged 3 commits into from
Mar 11, 2024
Merged

feat(BrowserStorage): remember silent call / message per conversation #11719

merged 3 commits into from
Mar 11, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Mar 4, 2024 •
edited
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image
image image

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added 3. to review bug feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client feature: call 📹 Voice and video calls labels Mar 4, 2024
@Antreesy Antreesy added this to the 💞 Next Major (29) milestone Mar 4, 2024
@Antreesy Antreesy self-assigned this Mar 4, 2024
@Antreesy Antreesy changed the title fix(BrowserStorage): cleanup empty entries in BrowserStorage feat(BrowserStorage): remember silent call / message per conversation Mar 4, 2024
@Antreesy Antreesy force-pushed the fix/10085/cleanup-bg-per-room branch from a6a8168 to 285a229 Compare March 4, 2024 21:10
@Antreesy Antreesy force-pushed the feat/10085/silent-settings-per-room branch from 224b612 to fada3f1 Compare March 4, 2024 21:13
@Antreesy Antreesy force-pushed the fix/10085/cleanup-bg-per-room branch from 285a229 to 4a7b43b Compare March 7, 2024 17:13
@Antreesy Antreesy force-pushed the feat/10085/silent-settings-per-room branch from fada3f1 to 5ac8831 Compare March 7, 2024 17:16
@Antreesy Antreesy marked this pull request as ready for review March 7, 2024 17:16
@Antreesy Antreesy requested review from nickvergessen and ShGKme March 7, 2024 17:16
@Antreesy Antreesy force-pushed the fix/10085/cleanup-bg-per-room branch 2 times, most recently from 150005c to e775fb1 Compare March 7, 2024 22:01
Base automatically changed from fix/10085/cleanup-bg-per-room to main March 7, 2024 22:09
@Antreesy Antreesy force-pushed the feat/10085/silent-settings-per-room branch from 5ac8831 to 0cfdb7e Compare March 8, 2024 10:21
@Antreesy Antreesy requested a review from DorraJaouad March 11, 2024 08:00
DorraJaouad
DorraJaouad approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ✅

src/components/MediaSettings/MediaSettings.vue Outdated Show resolved Hide resolved
src/components/NewMessage/NewMessage.vue Outdated Show resolved Hide resolved
Antreesy added 3 commits March 11, 2024 12:22
@Antreesy
feat(MediaSettings): remember silent call per conversation
9471468 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
feat(NewMessage): remember silent chat per conversation
8084f29 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
chore(typescript): set avatarService extension explicitly
4deb390 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the feat/10085/silent-settings-per-room branch from 0cfdb7e to 4deb390 Compare March 11, 2024 11:30
@Antreesy Antreesy enabled auto-merge March 11, 2024 11:31
@Antreesy Antreesy merged commit e3f5f01 into main Mar 11, 2024
46 checks passed
@Antreesy Antreesy deleted the feat/10085/silent-settings-per-room branch March 11, 2024 11:40
@Antreesy Antreesy mentioned this pull request Mar 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@Antreesy Antreesy

Labels
3. to review bug feature: call 📹 Voice and video calls feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
v19.0.0-beta.2
3 participants
@Antreesy @DorraJaouad @nickvergessen