Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable28] fix(screenshare): fix missing screenshare button #11721

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Mar 5, 2024

Came back with the recent vue-lib updates:
image

For now, splitting NcActions into NcActions + NcButton helps on main, but need to take a look into focus trap error, as it affects every single component

DorraJaouad and others added 2 commits March 5, 2024 09:34
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy changed the title [stable28] chore(screenshare): get rid of duplicated properties [stable28] fix(screenshare): fix missing screenshare button Mar 5, 2024
@Antreesy Antreesy requested review from ShGKme and removed request for SystemKeeper March 5, 2024 08:50
@Antreesy Antreesy force-pushed the backport/11720/stable28 branch from 865c656 to 2abb696 Compare March 5, 2024 08:50
@Antreesy Antreesy marked this pull request as ready for review March 5, 2024 08:51
@Antreesy
Copy link
Contributor

Antreesy commented Mar 5, 2024

cc @ShGKme for manual backport changes and vue-lib bug awareness

@ShGKme
Copy link
Contributor

ShGKme commented Mar 7, 2024

Am I missing something? I don't see any changes from that PR in this backport

@Antreesy
Copy link
Contributor

Antreesy commented Mar 7, 2024

I don't see any changes from that PR in this backport

There is a splitted NcButton

@Antreesy Antreesy merged commit 12ee8b0 into stable28 Mar 7, 2024
45 checks passed
@Antreesy Antreesy deleted the backport/11720/stable28 branch March 7, 2024 22:15
@nickvergessen
Copy link
Member

Should release this for 28, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants