Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(federation): Expose local token with the invite so UI can render proxy avatars #11777

Merged
merged 3 commits into from
Mar 12, 2024
Merged

fix(federation): Expose local token with the invite so UI can render proxy avatars #11777

merged 3 commits into from
Mar 12, 2024

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Mar 12, 2024 •
edited
Loading

🛠️ API Checklist

🚧 Tasks

  • Fix missing token so the UI can start the avatar
  • Handle invites as "OK" on the avatar endpoint even when not accepted yet

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen added 3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: federation 🌐 labels Mar 12, 2024
@nickvergessen nickvergessen added this to the 💞 Next Beta (29) milestone Mar 12, 2024
@nickvergessen nickvergessen requested a review from Antreesy March 12, 2024 09:26
@nickvergessen nickvergessen self-assigned this Mar 12, 2024
@Antreesy
Copy link
Contributor

Will take care of frontend part

nickvergessen and others added 2 commits March 12, 2024 10:46
@nickvergessen @Antreesy
fix(federation): Expose local token with the invite so UI can render …
f65db24 
…the avatar

Signed-off-by: Joas Schilling <coding@schilljs.com>
@Antreesy
fix(federation): show proxy avatars in InvitationHandler
04d51b3 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the bugfix/noid/expose-localToken-with-invites-to-render-avatar branch from 6ad716a to 04d51b3 Compare March 12, 2024 10:33
@nickvergessen
fix(federation): Allow accessing avatars with pending invites
5907dc4 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member Author

Fixed the access check, works fine for me now 👍🏼

@nickvergessen nickvergessen enabled auto-merge March 12, 2024 14:08
Antreesy
Antreesy approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@Antreesy Antreesy changed the title fix(federation): Expose local token with the invite so UI can render … fix(federation): Expose local token with the invite so UI can render proxy avatars Mar 12, 2024
@nickvergessen nickvergessen merged commit e3d3e5d into main Mar 12, 2024
65 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/expose-localToken-with-invites-to-render-avatar branch March 12, 2024 14:37
@nickvergessen nickvergessen mentioned this pull request Mar 12, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

Assignees

@nickvergessen nickvergessen

Labels
3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: federation 🌐
Projects
None yet
Milestone
v19.0.0-beta.2
Development

Successfully merging this pull request may close these issues.

Federated invitations follow-ups
2 participants
@nickvergessen @Antreesy