Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(federation): Inform federated servers/users when deleting a conversation #11790

Merged
merged 1 commit into from
Mar 13, 2024
Merged

fix(federation): Inform federated servers/users when deleting a conversation #11790

merged 1 commit into from
Mar 13, 2024

Conversation

nickvergessen
Copy link
Member

☑️ Resolves

  • Create a room
  • Add a federated user
  • As FU accept the invite
  • As host delete the room
  • Before: The room and invite is still present in the DB
  • After: Now the invite and participant are cleaned up immediately (and the room after the next cron run)

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen
fix(federation): Notify federated users when deleting a conversation
1ac133e 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the 💞 Next Beta (29) milestone Mar 13, 2024
@nickvergessen nickvergessen self-assigned this Mar 13, 2024
@nickvergessen nickvergessen enabled auto-merge March 13, 2024 10:49
@nickvergessen nickvergessen merged commit 3ae964b into main Mar 13, 2024
64 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/notify-federated-users-when-deleting-conversation branch March 13, 2024 11:01
@nickvergessen nickvergessen mentioned this pull request Mar 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@SystemKeeper SystemKeeper Awaiting requested review from SystemKeeper

Assignees

@nickvergessen nickvergessen

Labels
3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: conversations 👥 feature: federation 🌐
Projects
None yet
Milestone
v19.0.0-beta.2
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @Antreesy