Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(federation): Respect setReadMarker=1 on proxied ChatController::r… #11792

Merged
merged 1 commit into from
Mar 13, 2024
Merged

fix(federation): Respect setReadMarker=1 on proxied ChatController::r… #11792

merged 1 commit into from
Mar 13, 2024

Conversation

nickvergessen
Copy link
Member

…eceiveMessage()

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen
fix(federation): Respect setReadMarker=1 on proxied ChatController::r…
d94254c 
…eceiveMessage()

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added 3. to review bug feature: chat 💬 Chat and system messages feature: api 🛠️ OCS API for conversations, chats and participants feature: federation 🌐 labels Mar 13, 2024
@nickvergessen nickvergessen added this to the 💞 Next Beta (29) milestone Mar 13, 2024
@nickvergessen nickvergessen self-assigned this Mar 13, 2024
SystemKeeper
SystemKeeper approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@SystemKeeper SystemKeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should update the docs that this only works when lookIntoFuture is also set

@nickvergessen nickvergessen enabled auto-merge March 13, 2024 13:22
@nickvergessen nickvergessen merged commit f049aaf into main Mar 13, 2024
64 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/respect-setReadMarker-on-receiveMessage branch March 13, 2024 13:24
@nickvergessen
Copy link
Member Author

I think we should update the docs that this only works when lookIntoFuture is also set

Always was the case btw, doesn't make a lot of sense when fetching the history.
There are quite many parameters that are only used in either mode... should finally split into 2 endpoints

@SystemKeeper
Copy link
Contributor

Yea, guess that makes sense in the long run

@nickvergessen nickvergessen mentioned this pull request Mar 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SystemKeeper SystemKeeper SystemKeeper approved these changes

@Ivansss Ivansss Awaiting requested review from Ivansss

Assignees

@nickvergessen nickvergessen

Labels
3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: chat 💬 Chat and system messages feature: federation 🌐
Projects
None yet
Milestone
v19.0.0-beta.2
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @SystemKeeper