fix(API): Use Room::isFederatedConversation() consistantly #11843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
3. to review
bug
feature: api 🛠️
nickvergessen
commented
Mar 18, 2024
| @@ -401,8 +401,7 @@ protected function fixMimeTypeOfVoiceMessage(ShareCreatedEvent|BeforeDuplicateSh | |||
| return; | |||
| } | |||
| $room = $this->manager->getRoomByToken($share->getSharedWith()); | |||
| if ($room->getRemoteServer() !== '') { | |||
| // FIXME this should be blocked up front | |||
There was a problem hiding this comment.
Here is the unequal line count of the diff
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
bugfix/noid/use-Room-isFederatedConversation
branch
from
6be9fff to
3416398
Compare
SystemKeeper
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ API Checklist
🏁 Checklist
docs/has been updated or is not required