Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(LeftSidebar): rearrange conversation fast creating options #11893

Merged
merged 4 commits into from
Mar 27, 2024
Merged

feat(LeftSidebar): rearrange conversation fast creating options #11893

merged 4 commits into from
Mar 27, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Mar 22, 2024 •
edited
Loading

☑️ Resolves

  • Fix "Create new conversation" shows above more useful conversation results in search #11632
    • Move "Create new conversation" under current conversations
    • Add sublines to indicate that user is starting a new conversation from search results
    • Decrease margin between sections
  • Show user status for known users in search results
  • Add fast option to create group conversation with federated user from search results
    • API provides entrypoint, would be a good base for follow-up 1-1 federated rooms

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After 🏚️ Before 🏡 After
image image image image
image image image image
Not available image - -

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team

@Antreesy Antreesy added this to the 💞 Next Beta (29) milestone Mar 22, 2024
@Antreesy Antreesy self-assigned this Mar 22, 2024
@Antreesy Antreesy force-pushed the feat/11632/separate-new-conv branch from ee5211e to 671b313 Compare March 22, 2024 09:23
@Antreesy Antreesy force-pushed the feat/11632/separate-new-conv branch 2 times, most recently from 9bcd7cc to e3c8b88 Compare March 22, 2024 13:26
@DorraJaouad
Copy link
Contributor

I think we lost arrow navigation 🙈

@Antreesy
feat(LeftSidebar): move fast creating under current conversations, ad…
6554cde 
…d subnames

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the feat/11632/separate-new-conv branch from 1c768b0 to bc2edb2 Compare March 23, 2024 14:09
@Antreesy
Copy link
Contributor Author

Antreesy commented Mar 23, 2024 •
edited
Loading

I think we lost arrow navigation 🙈

Yeah, due to vue-lib changes (again)

I rewrote code, so we don't depend on selector (which could be changed), only on presense of data-nav-id

jancborchardt
jancborchardt reviewed Mar 26, 2024
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Design-wise it looks nice! :)

@Antreesy Antreesy requested a review from DorraJaouad March 26, 2024 18:00
Antreesy added 3 commits March 27, 2024 09:31
@Antreesy
fix(useArrowNavigation): detach navigation from using class selector
464426a 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
feat(ParticipantsTab): attach arrow navigation to search results, ali…
d22242a 
…gn list styles with LeftSidebar

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
feat(LeftSidebar): use AvatarWrapper for users, add fast creating opt…
1bfff6e 
…ion for federated users

- lint import order

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the feat/11632/separate-new-conv branch from 7d05b9d to 1bfff6e Compare March 27, 2024 08:33
DorraJaouad
DorraJaouad approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ✅

@Antreesy Antreesy merged commit 2a80dee into main Mar 27, 2024
46 checks passed
@Antreesy Antreesy deleted the feat/11632/separate-new-conv branch March 27, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt left review comments

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

@Antreesy Antreesy

Labels
3. to review enhancement feature: conversations 👥 feature: federation 🌐 feature: frontend 🖌️ "Web UI" client
Projects
💬 Talk team
Archived in project
Milestone
v19.0.0-rc.1
Development

Successfully merging this pull request may close these issues.

"Create new conversation" shows above more useful conversation results in search
4 participants
@Antreesy @DorraJaouad @jancborchardt @nickvergessen