Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(PresenterOverlay): Add grabbing cursor #11903

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Conversation

DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Mar 22, 2024

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏡 After

Recording.2024-03-22.161350.mp4

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@DorraJaouad DorraJaouad added this to the 💞 Next Beta (29) milestone Mar 22, 2024
@DorraJaouad DorraJaouad requested a review from Antreesy March 22, 2024 16:01
@DorraJaouad DorraJaouad self-assigned this Mar 22, 2024
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, didn't test it, but by screencast lookg and works good)
Couple of comments:

src/components/CallView/CallView.vue Outdated Show resolved Hide resolved
src/components/CallView/CallView.vue Show resolved Hide resolved
src/components/CallView/CallView.vue Outdated Show resolved Hide resolved
src/components/CallView/CallView.vue Outdated Show resolved Hide resolved
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested now

src/components/CallView/shared/PresenterOverlay.vue Outdated Show resolved Hide resolved
src/components/CallView/shared/VideoVue.vue Show resolved Hide resolved
… and add grabbing effects

Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad force-pushed the enh/11869/add-grabber-pointer branch from a9d8e5a to 2a06419 Compare March 26, 2024 15:31
@Antreesy Antreesy merged commit f28c5c4 into main Mar 26, 2024
46 checks passed
@Antreesy Antreesy deleted the enh/11869/add-grabber-pointer branch March 26, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use cursor:grab for the floating videostream on top of screenshares
3 participants