Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(UX): Show a warning when bruteforce protection is throttling #11927

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Mar 25, 2024

☑️ Resolves

Bildschirmfoto vom 2024-03-25 17-27-50

For testing add:

$response->addHeader('X-Nextcloud-Bruteforce-Throttled', '25000ms');

Before
https://github.com/nextcloud/server/blob/25309bcb45232bf30fe719bac1776f0136f7cd7a/lib/private/AppFramework/Middleware/Security/BruteForceMiddleware.php#L136

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok
Can we include request ID or user IP for backtracking?

@nickvergessen
Copy link
Member Author

Well that will be any "join" of a conversation. But yeah might make sense to add some info the sysadmin can find locally

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/noid/show-warning-when-bfp-more-than-5s branch from 1896959 to 6fd87cb Compare March 26, 2024 07:36
@nickvergessen nickvergessen merged commit 27152f0 into main Mar 26, 2024
46 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/show-warning-when-bfp-more-than-5s branch March 26, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants