feat(MediaSettings): preferred media devices selection 🎤📹 #11936

Antreesy · 2024-03-26T13:31:55Z

☑️ Resolves

Fix Media settings sometimes reset to a wrong microphone #9902
Add button to manually refresh devices list:
- event listener tracks only change of physical devices (USB-connected)
- allow to get in the list such inputs as bluetooth, mini-jack, virtual devices
feat(media): list device in preferences order
- device goes on top of the list (above unplugged devices) every time user closes media settings dialog (when joining a call or applying new devices during the call
- list can be called with window.OCA.Talk.mediaDevicesManager.listDevices() via devtools

Tip

Use

window.OCA.Talk.mediaDevicesManager.listDevices()

to get list in the console

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before	🏡 After

Screencast.from.11.04.2024.15.18.10.webm

🚧 Tasks

Replace fallback id with preferences (or combine)
Update selected device based on preferences
Add showWarning for changes / fallback / preferences
check why audio/video is disabled on device change during call

🏁 Checklist

🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
🖥️ Tested with Desktop client or should not be risky for it
🖌️ Design was reviewed, approved or inspired by the design team
⛑️ Tests are included or not possible
📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

DorraJaouad · 2024-04-02T10:57:30Z

event listener tracks only change of physical devices (USB-connected)

Tested on Google chrome and brave, my Bluetooth headset is detected with event listener.

DorraJaouad

Logic is almost correctly implemented, nice work!

src/services/mediaDevicePreferences.ts

Antreesy · 2024-04-10T13:48:50Z

Current state to test (step by step)

Select devices and start a call (they are on top of the list - preffered)

Media devices:
  Audio input:
    1. Family 17h (Models 10h-1fh) HD Audio Controller Analog Stereo (selected)
    2. AUKEY PC-LM1E Camera Analog Stereo

  Video input:
    1. BisonCam,NB Pro (5986:9102) (selected)
    2. AUKEY PC-LM1E Camera (1bcf:0001)

Select other devices and start a call (now they are preffered)

  Media devices:
  Audio input:
    1. AUKEY PC-LM1E Camera Analog Stereo (selected)
    2. Family 17h (Models 10h-1fh) HD Audio Controller Analog Stereo

  Video input:
    1. AUKEY PC-LM1E Camera (1bcf:0001) (selected)
    2. BisonCam,NB Pro (5986:9102)

Disconnect first device and start a call (first is unavilable, but still counts as preffered, if will be connected):

Media devices:
  Audio input:
    1. AUKEY PC-LM1E Camera Analog Stereo (unplugged)
    2. Family 17h (Models 10h-1fh) HD Audio Controller Analog Stereo (selected)

  Video input:
    1. AUKEY PC-LM1E Camera (1bcf:0001) (unplugged)
    2. BisonCam,NB Pro (5986:9102) (selected)
    ```

- event listener tracks only change of physical devices (USB-connected) - allow to get in the list such inputs as bluetooth, mini-jack, virtual devices Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>

ShGKme

Just awesome 🔥

Tested with @Antreesy with plugging in-out USB devices.

Not tested yet with Bluetooth devices and virtual devices / enabling/disabling devices in the system

src/services/mediaDevicePreferences.ts

ShGKme · 2024-04-11T13:51:07Z

src/services/mediaDevicePreferences.ts

+	// eslint-disable-next-line no-console
+	console.log(`Media devices:
+  Audio input:
+${audioInputList.map(getDeviceString).join('\n')}
+
+  Video input:
+${videoInputList.map(getDeviceString).join('\n')}
+`)


Do not forget to remove the debug log :P

That's needed to list devices in the console (so user can pass some information to admin, e.g)

Then it should not be log

src/services/mediaDevicePreferences.ts

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>

…lable Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>

DorraJaouad

scenario ( devices A (bluetooth headset), B (virtual mic), C(external mic)):

[A+B] select A in presence of B
[B] unplug A , B was automatically selected
[B+C] plug C and use it
[A+B+C] plug A, A was automatically selected

DorraJaouad · 2024-04-11T14:41:08Z

src/utils/webrtc/MediaDevicesManager.js

@@ -200,14 +212,14 @@ MediaDevicesManager.prototype = {
 					// Couldn't find device by id
 					console.debug('Could not find previous audio device, falling back to default/first device in the list', BrowserStorage.getItem('audioInputId'), this.attributes.devices)
 				}
-				this.attributes.audioInputId = this._fallbackAudioInputId
+				this.attributes.audioInputId = getFirstAvailableMediaDevice(devices, this._preferenceAudioInputList, this._fallbackAudioInputId) ?? 'default'


this._fallbackAudioInputId can be omitted given that we have the list now, but let's do it next time.

nickvergessen · 2024-04-11T15:20:41Z

/backport to stable29

Antreesy added 2. developing enhancement feature: frontend 🖌️ "Web UI" client labels Mar 26, 2024

Antreesy added this to the 💙 Next Major (30) milestone Mar 26, 2024

Antreesy requested a review from DorraJaouad March 26, 2024 13:31

Antreesy self-assigned this Mar 26, 2024

Antreesy force-pushed the fix/9902/preffered-media-device branch 2 times, most recently from 7a64764 to 5456dae Compare March 28, 2024 16:03

DorraJaouad reviewed Apr 2, 2024

View reviewed changes

src/services/mediaDevicePreferences.ts Outdated Show resolved Hide resolved

src/services/mediaDevicePreferences.ts Outdated Show resolved Hide resolved

Antreesy force-pushed the fix/9902/preffered-media-device branch from 5456dae to fd435b2 Compare April 10, 2024 13:48

Antreesy force-pushed the fix/9902/preffered-media-device branch 2 times, most recently from f7d04df to a18fdcc Compare April 11, 2024 13:07

Antreesy added 3 commits April 11, 2024 15:14

feat(media): manually refresh devices list

f12aaa5

- event listener tracks only change of physical devices (USB-connected) - allow to get in the list such inputs as bluetooth, mini-jack, virtual devices Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>

feat(media): rank and list device preferences

13d0d2c

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>

feat(media): substitute fallback device with preferred device

2a87eff

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>

Antreesy force-pushed the fix/9902/preffered-media-device branch from a18fdcc to 2a87eff Compare April 11, 2024 13:15

Antreesy requested a review from ShGKme April 11, 2024 13:15

Antreesy marked this pull request as ready for review April 11, 2024 13:20

Antreesy requested a review from DorraJaouad April 11, 2024 13:41

ShGKme reviewed Apr 11, 2024

View reviewed changes

Antreesy added 2 commits April 11, 2024 16:34

fix(media): post-review changes

50746ae

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>

fix(media): show media settings modal on click, if device is not avai…

1898fd9

…lable Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>

DorraJaouad approved these changes Apr 11, 2024

View reviewed changes

Antreesy mentioned this pull request Apr 11, 2024

preferred media devices follow-up #12064

Closed

6 tasks

Antreesy merged commit f458624 into main Apr 11, 2024
45 checks passed

Antreesy deleted the fix/9902/preffered-media-device branch April 11, 2024 14:54

backportbot bot added the backport-request label Apr 11, 2024

backportbot bot mentioned this pull request Apr 11, 2024

[stable29] feat(MediaSettings): preferred media devices selection 🎤📹 #12067

Merged

backportbot bot removed the backport-request label Apr 11, 2024

danxuliu mentioned this pull request Apr 22, 2024

Device preferences are not saved when set from Talk settings #12185

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(MediaSettings): preferred media devices selection 🎤📹 #11936

feat(MediaSettings): preferred media devices selection 🎤📹 #11936

Antreesy commented Mar 26, 2024 •

edited

Loading

DorraJaouad commented Apr 2, 2024

DorraJaouad left a comment

Antreesy commented Apr 10, 2024

ShGKme left a comment

ShGKme Apr 11, 2024

Antreesy Apr 11, 2024

ShGKme Apr 11, 2024

DorraJaouad left a comment

DorraJaouad Apr 11, 2024

nickvergessen commented Apr 11, 2024

feat(MediaSettings): preferred media devices selection 🎤📹 #11936

feat(MediaSettings): preferred media devices selection 🎤📹 #11936

Conversation

Antreesy commented Mar 26, 2024 • edited Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🚧 Tasks

🏁 Checklist

DorraJaouad commented Apr 2, 2024

DorraJaouad left a comment

Choose a reason for hiding this comment

Antreesy commented Apr 10, 2024

ShGKme left a comment

Choose a reason for hiding this comment

ShGKme Apr 11, 2024

Choose a reason for hiding this comment

Antreesy Apr 11, 2024

Choose a reason for hiding this comment

ShGKme Apr 11, 2024

Choose a reason for hiding this comment

DorraJaouad left a comment

Choose a reason for hiding this comment

DorraJaouad Apr 11, 2024

Choose a reason for hiding this comment

nickvergessen commented Apr 11, 2024

Antreesy commented Mar 26, 2024 •

edited

Loading