Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FilePicker): provide correct container for FilePicker #11939

Merged
merged 1 commit into from
Mar 27, 2024
Merged

fix(FilePicker): provide correct container for FilePicker #11939

merged 1 commit into from
Mar 27, 2024

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

  • Fix cases when FilePicker is shown behind the modal

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

hard to reproduce

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it

@Antreesy
fix(FilePicker): provide correct container for FilePicker
7850fdb 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added this to the 💞 Next RC (29) milestone Mar 26, 2024
@Antreesy Antreesy requested a review from DorraJaouad March 26, 2024 18:10
@Antreesy Antreesy self-assigned this Mar 26, 2024
DorraJaouad
DorraJaouad approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ✅
Though I would suggest to improve container binding later and not to keep so many hard-coded ones 🙈

@Antreesy Antreesy merged commit 62596a9 into main Mar 27, 2024
46 checks passed
@Antreesy Antreesy deleted the fix/noid/filepicker-container branch March 27, 2024 09:41
@Antreesy
Copy link
Contributor Author

/backport to stable28

@backportbot backportbot bot mentioned this pull request Mar 27, 2024
Merged
This was referenced Mar 28, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review bug feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
v19.0.0-rc.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Antreesy @DorraJaouad