-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow-up: chat scrolling refactoring #11943
Conversation
UPD; or just ignore it :p. It is not needed in handling opening conversations. If the user is actually not a participant, it seems blocked by API. --> dropped this idea because it might lead to brute force protection triggered. UPD2: used conversation store, as it is instantly available |
1ee802a
to
0c0a82c
Compare
Focused message from URL doesn't focus correctly sometimes 🥲 |
6132f8e
to
624ebf1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked only the last commits (unrelated to scrolling logic):
624ebf1
to
e7cebc2
Compare
e7cebc2
to
a325ae0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed during pair-review, seems to work much better. Seems that even the opening of every chat at the top is resolved! One more thing to try to reproduce and fix:
I'm quite impressed with the final result, to be honest =P cc @nickvergessen @ShGKme @danxuliu : I'd suggest to look through it once more thoroughly (maybe after RC), and at best - compile the desktop client with this PR and use it for a while. If we consider it good enough, then could backport for 19.0.1 |
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
a325ae0
to
a731695
Compare
/backport to stable29 |
☑️ Resolves
TO-DO
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
Conversation switching before
Recording.2024-04-19.before.mp4
Conversation switching after
Recording.2024-04-19.after.mp4
🏁 Checklist