Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MessageButtonsBar): revert to main selector #11945

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

DorraJaouad
Copy link
Contributor

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad added regression feature: chat 💬 Chat and system messages labels Mar 27, 2024
@DorraJaouad DorraJaouad added this to the 💞 Next RC (29) milestone Mar 27, 2024
@DorraJaouad DorraJaouad requested a review from Antreesy March 27, 2024 13:07
@DorraJaouad DorraJaouad self-assigned this Mar 27, 2024
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a test or test list or something, so that for future changes changing this again we know what to test to avoid a regression?

@DorraJaouad
Copy link
Contributor Author

Could we add a test or test list or something, so that for future changes changing this again we know what to test to avoid a regression?

I am not sure if it is testable with unit test, it's fine sometimes to have elements rendered after popover/modal and sometimes not.
@Antreesy wdy ?

@Antreesy
Copy link
Contributor

Antreesy commented Mar 27, 2024

We could add some integration or e2e tests, where:

  • complete App / ChatView / MessagesList is rendered inside of parent (as in production);
  • the list (or rule) is defined for NcModals which should be always appended to the body (not inside the other component or modal), and checking it during test
  • ...
  • rest in the issue

@Antreesy Antreesy merged commit bbafe70 into main Mar 28, 2024
46 checks passed
@Antreesy Antreesy deleted the fix/11932/fix-date-sep-overlapping branch March 28, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: chat 💬 Chat and system messages regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

z-index: Date item above reaction emoji picker
3 participants