Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(federation): Fix empty strings being null in Oracle #11978

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

nickvergessen
Copy link
Member

☑️ Resolves

🛠️ API Checklist

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen added 3. to review bug feature: chat 💬 Chat and system messages feature: api 🛠️ OCS API for conversations, chats and participants feature: federation 🌐 labels Mar 28, 2024
@nickvergessen nickvergessen added this to the 💙 Next Major (30) milestone Mar 28, 2024
@nickvergessen nickvergessen self-assigned this Mar 28, 2024
@nickvergessen
Copy link
Member Author

/backport to stable29

@nickvergessen nickvergessen force-pushed the bugfix/11972/fix-empty-string-being-null branch from 0c6b8fe to 1725035 Compare April 3, 2024 15:19
Signed-off-by: Joas Schilling <coding@schilljs.com>
We can't sort by token here as the name-to-token map is overwritten as both rooms have the same name

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/11972/fix-empty-string-being-null branch from 1725035 to 9782239 Compare April 4, 2024 08:34
@nickvergessen nickvergessen merged commit d931bc1 into main Apr 4, 2024
64 checks passed
@nickvergessen nickvergessen deleted the bugfix/11972/fix-empty-string-being-null branch April 4, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: chat 💬 Chat and system messages feature: federation 🌐
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Federation integration tests with oracle fail
1 participant