fix(MessagesSystemGroup): Follow-up correct collapsed property #11992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DorraJaouad
added
regression
feature: chat 💬
DorraJaouad
force-pushed
the
fix/noid/unread-marker-in-system-messages
branch
from
1557843 to
35f5b39
Compare
ShGKme
reviewed
Apr 4, 2024
src/components/MessagesList/MessagesGroup/MessagesSystemGroup.vue
Outdated
Show resolved
Hide resolved
Antreesy
reviewed
Apr 8, 2024
src/components/MessagesList/MessagesGroup/MessagesSystemGroup.vue
Outdated
Show resolved
Hide resolved
src/components/MessagesList/MessagesGroup/MessagesSystemGroup.vue
Outdated
Show resolved
Hide resolved
DorraJaouad
force-pushed
the
fix/noid/unread-marker-in-system-messages
branch
2 times, most recently
from
a56875f to
7863759
Compare
Antreesy
reviewed
Apr 9, 2024
src/components/MessagesList/MessagesGroup/MessagesSystemGroup.vue
Outdated
Show resolved
Hide resolved
src/components/MessagesList/MessagesGroup/MessagesSystemGroup.vue
Outdated
Show resolved
Hide resolved
…essage type to be dependent on the length of messages in the group. If it is only one, it is forcibly and always not collapsed ( it is a normal system messages without combined header) Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
DorraJaouad
force-pushed
the
fix/noid/unread-marker-in-system-messages
branch
from
7863759 to
f083e52
Compare
|
/backport to stable29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
actor removedmessages, collapse previously open groups with unread marker #11876🖌️ UI Checklist
🖼️ Screenshots / Screencasts
Both screenshots have last read message is the last system message shown
🚧 Tasks
TO-DO next:
MessagesSystemGroupcomponent should contain only one group (1 combined message and its collapsed messages)groupIsCollapsedlogic toMessagesList, so it can maintain manual collapsed state when switching between conversations.🏁 Checklist