-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: define explicit reactivity for webrtc models #11993
Conversation
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
adb6443
to
853249c
Compare
// FIXME: use reactive instead of ref after migration to vue 3 | ||
this.callParticipantModels = ref([]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Vue warn]: Avoid using Array as root value for reactive() as it cannot be tracked in watch() or watchEffect(). Use ref() instead. This is a Vue-2-only limitation.
As we don't use it in watch
or watchEffect
, reactive
would also work here.
Though, it will show the error in the console...
So, I don't know what is the best way here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, reactive
works fine but those errors were annoying, I would keep ref
temporarily.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for separating into commits
/backport to stable29 |
☑️ Resolves
Components affected
🏁 Checklist