desktop: add screen sharing support #12003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable29 |
Merged
ShGKme
force-pushed
the
desktop/screen-sharing-support
branch
from
0ff3a50 to
ff633a8
Compare
5 tasks
ShGKme
commented
Apr 4, 2024
Comment on lines
-37
to
41
| if (typeof window === 'undefined' || window.location.protocol === 'http:') { | ||
| if (!IS_DESKTOP && (typeof window === 'undefined' || window.location.protocol === 'http:')) { | ||
| error = new Error('NavigatorUserMediaError') | ||
| error.name = 'HTTPS_REQUIRED' | ||
| return callback(error) | ||
| } |
There was a problem hiding this comment.
P.S. This code block seems to be never actually used. We check screenSharing support in the button handler anyway.
There was a problem hiding this comment.
this code is a library called simplewebrtc which was discontinued and then copied into our source :P
|
Back to draft. One case is missing - sharing all the screens at the same time together with the audio. It is a special case in Electron :( |
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
force-pushed
the
desktop/screen-sharing-support
branch
from
ff633a8 to
a4f3607
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖌️ UI Checklist
🚧 Tasks
🏁 Checklist