Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(MessagesButtonsBar): exclude click on emoji picker from outside click event listener #12058

Merged
merged 1 commit into from
Apr 11, 2024
Merged

fix(MessagesButtonsBar): exclude click on emoji picker from outside click event listener #12058

merged 1 commit into from
Apr 11, 2024

Conversation

DorraJaouad
Copy link
Contributor

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

Recording.2024-04-11.115521.mp4

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@DorraJaouad
fix(MessagesButtonsBar): excluded click on emoji picker from outside …
bd12234 
…click event listener

Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad added this to the 💙 Next Major (30) milestone Apr 11, 2024
@DorraJaouad DorraJaouad requested a review from Antreesy April 11, 2024 09:56
@DorraJaouad DorraJaouad self-assigned this Apr 11, 2024
@nickvergessen
Copy link
Member

/backport to stable29

@Antreesy Antreesy merged commit 7adbb1f into main Apr 11, 2024
45 checks passed
@Antreesy Antreesy deleted the fix/12046/emoji-picker-clikc branch April 11, 2024 13:22
@backportbot backportbot bot mentioned this pull request Apr 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

Assignees

@DorraJaouad DorraJaouad

Labels
feature: frontend 🖌️ "Web UI" client regression
Projects
None yet
Milestone
v20.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

Clicking into search box of emoji picker closes it
3 participants
@DorraJaouad @nickvergessen @Antreesy