Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spdx 2 - Script run, do not modify #12207

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Spdx 2 - Script run, do not modify #12207

merged 2 commits into from
Apr 26, 2024

Conversation

nickvergessen
Copy link
Member

☑️ Resolves

  • Fix #…

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
Screenshot before Screenshot after

🚧 Tasks

  • ...

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

🛠️ API Checklist

🚧 Tasks

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen changed the title Spdx 2 Spdx 2 - Script testing, do not modify Apr 25, 2024
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen changed the title Spdx 2 - Script testing, do not modify Spdx 2 - Script run, do not modify Apr 26, 2024
Signed-off-by: Joas Schilling <coding@schilljs.com>
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it is okay, while I would have preferred to keep the original statements and only use the generic one for files that formerly lacked a header in general.

@nickvergessen nickvergessen merged commit 0ace1fe into main Apr 26, 2024
63 checks passed
@nickvergessen nickvergessen deleted the spdx-2 branch April 26, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants