Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(API): Avoid changing variable types #12247

Merged
merged 1 commit into from
May 2, 2024
Merged

fix(API): Avoid changing variable types #12247

merged 1 commit into from
May 2, 2024

Conversation

nickvergessen
Copy link
Member

🛠️ API Checklist

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen
fix(API): Avoid changing variable types
6387dcf 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added 3. to review feature: api 🛠️ OCS API for conversations, chats and participants technical debt labels May 2, 2024
@nickvergessen nickvergessen added this to the 💙 Next Major (30) milestone May 2, 2024
@nickvergessen nickvergessen requested review from nfebe and danxuliu May 2, 2024 08:49
@nickvergessen nickvergessen self-assigned this May 2, 2024
@danxuliu danxuliu merged commit acb1bbe into main May 2, 2024
63 checks passed
@danxuliu danxuliu deleted the bugfix/noid/avoid-changing-types branch May 2, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danxuliu danxuliu danxuliu approved these changes

@nfebe nfebe Awaiting requested review from nfebe

Assignees

@nickvergessen nickvergessen

Labels
3. to review feature: api 🛠️ OCS API for conversations, chats and participants technical debt
Projects
None yet
Milestone
v20.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @danxuliu