Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(prevent-unload): replace PreventUnload with native browser functionality #12349

Merged
merged 2 commits into from
May 13, 2024
Merged

fix(prevent-unload): replace PreventUnload with native browser functionality #12349

merged 2 commits into from
May 13, 2024

Conversation

Antreesy
Copy link
Contributor

Signed-off-by: Maksim Sukharev antreesy.web@gmail.com### ☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

No changes

🚧 Tasks

  • Test

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it

Antreesy added 2 commits May 13, 2024 17:59
@Antreesy
fix(deps): replace PreventUnload with native browser functionality
32fa5dc 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
chore(deps): uninstall "vue-prevent-unload" library
307c374 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added this to the 💙 Next Major (30) milestone May 13, 2024
@Antreesy Antreesy requested review from ShGKme and DorraJaouad May 13, 2024 16:07
@Antreesy Antreesy self-assigned this May 13, 2024
DorraJaouad
DorraJaouad approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Antreesy Antreesy merged commit 4235e91 into main May 13, 2024
46 checks passed
@Antreesy Antreesy deleted the fix/9448/prevent-unload branch May 13, 2024 16:27
@ShGKme ShGKme mentioned this pull request May 15, 2024
Open
47 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@Antreesy Antreesy

Labels
3. to review feature: frontend 🖌️ "Web UI" client technical debt
Projects
None yet
Milestone
v20.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Antreesy @DorraJaouad