Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vue3): fix automated tests #12362

Merged
merged 11 commits into from
May 28, 2024
Merged

feat(vue3): fix automated tests #12362

merged 11 commits into from
May 28, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented May 15, 2024

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

image

🚧 Tasks

  • Bring back tests for components when nextcloud/vue lib is migrated
  • Uninstall flush-promises

@Antreesy Antreesy changed the base branch from main to vue3 May 15, 2024 15:36
@ShGKme
Copy link
Contributor

ShGKme commented May 19, 2024

Note, you don't need to always import t in components for tests, it is not required. We can setup component's globals in the mount function, including installing plugins:
See:

Antreesy added 6 commits May 27, 2024 14:03
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/vue3/vue-test-utils branch from 5f910f6 to f9b5b27 Compare May 27, 2024 12:11
@Antreesy Antreesy requested a review from ShGKme May 27, 2024 12:12
@Antreesy Antreesy marked this pull request as ready for review May 27, 2024 12:12
@Antreesy Antreesy force-pushed the fix/vue3/vue-test-utils branch from 3cccba9 to 3abfb3f Compare May 27, 2024 12:52
@ShGKme
Copy link
Contributor

ShGKme commented May 27, 2024

Can you describe the fix(vue3): fix double emitting commit?

Antreesy added 5 commits May 28, 2024 19:13
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/vue3/vue-test-utils branch from 3abfb3f to e9ee53e Compare May 28, 2024 17:15
@Antreesy
Copy link
Contributor Author

Can you describe the fix(vue3): fix double emitting commit?

As was discussed in the office: Vue2 and Vue3 behave differently at this moment:

  • in Vue 2 component is destroyed before bubbling event is triggered
  • in Vue 3 event bubbles, (and fires twice), then got destroyed

@ShGKme ShGKme merged commit 9235a62 into vue3 May 28, 2024
44 checks passed
@ShGKme ShGKme deleted the fix/vue3/vue-test-utils branch May 28, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants